#mod-dev-talk Friday 16 July 2021
124 messages8 people
- A
- J
- J
- Ahttps://www.youtube.com/watch?v=KJGUixiqICU @Jack Papel
- J
- S
- J
- S06:41They have a good eat animation iirc
- A
Replying toJack PapelI was confused, I thought that was aether music for a second
tbf something like that would be baller as fuck in the aether06:42@rolecough cough(edited) - J
- SImagine having some sort of mod that let you play different music depending on what's going on.. such as in a dungeon06:46@Azzyypaaras 👀
- S
- J07:28good job
- J
- SYesterday, I found some gravitite ore and, having no pickaxe on hand, decided to levitate it into a button to obtain its gems. Alas, the only wood I had on me was skyroot, and skyroot could not be crafted into buttons. Today I rectify this issue, to right the wrongs caused to me, and prevent the suffering of all future players unfortunate enough to encounter such an unpleasant situation.(edited)
- J11:21Though, it wouldn't have dropped anyway afaik
- S
- S
data/the_aether/tags/blocks/aether_doors.json{ "replace": false, "values": [ "#the_aether:aether_wooden_doors" ] }data/the_aether/tags/blocks/aether_doors.json{ "replace": false, "values": [ "the_aether:skyroot_door", "the_aether:golden_oak_door", "the_aether:crystal_door", "the_aether:wisteria_door", "the_aether:orange_door" ] }data/minecraft/tags/blocks/doors.json{ "replace": false, "values": [ "#minecraft:wooden_doors", "minecraft:iron_door", "#the_aether:aether_doors" ] }data/minecraft/tags/blocks/wooden_doors.json{ "replace": false, "values": [ "minecraft:oak_door", "minecraft:spruce_door", "minecraft:birch_door", "minecraft:jungle_door", "minecraft:acacia_door", "minecraft:dark_oak_door", "minecraft:crimson_door", "minecraft:warped_door", "#the_aether:aether_wooden_doors" ] }11:40Why is it like this?11:40All of the related tags are done that way11:41Aether-specific variants of the vanilla tags, then including the aether tags in the vanilla tags, redundantly specifying vanilla blocks, and adding the same things to the same tag twice11:42All of the above could be replaced with this one file:data/minecraft/tags/blocks/wooden_doors.json
(edited){ "replace": false, "values": [ "the_aether:skyroot_door", "the_aether:golden_oak_door", "the_aether:crystal_door", "the_aether:wisteria_door", "the_aether:orange_door" ] }11:47Are the tags such asaether_wooden_doorsactually used? @Jack Papel - J11:49I imagine not though
- S
- JWhat do you guys think about this explosion power? https://drive.google.com/file/d/1QrD4uGrITzyUWSpfw7rROjk2AsYu_cvy/view?usp=sharing
- A
- K
- J
Replying toAzzyypaarasI feel criminally sleek for doing this
I've gotten to do this like a dozen times writing swet code. Pure bliss14:59Treasure it, there's nothing else like it - J
Replying toJack PapelWhat do you guys think about this explosion power? https://drive.google.com/file/d/1QrD4u…
Since you guys are online, any opinions about this? - C15:07also: on the tags issue, its not really required but it's done that way just to separate our stuff a little more, it just keeps it a bit neater, but ultimately is not really needed
- S
- C15:26if you don't, in IDEs the tags don't include them
- C
Replying toSollyAre the tags such as aether_wooden_doors actually used? @Jack Papel
They are split that way for cleanliness15:28and to prevent duplication15:29aether wooden doors is also used - S
- C
- SAnd why aether_doors is included in doors, despite wooden_doors being included in doors, and aether_wooden_doors being included in wooden_doors15:30I fail to see how it's cleaner
- S
Replying toCDAGamingThats also to prevent issues if mojang fjcks up
Why is that the aether's problem? - CBc i want this to be a stable port so id rather tagging not go wrong. The tags were designed the way they were to almost perfectly match vanillas plus allow more customizing from the individual groups(edited)15:34We could easily, in the future, do something special for the aether specific tags for example
- S
data/minecraft/tags/blocks/wooden_doors.json
Could just be{ "replace": false, "values": [ "minecraft:oak_door", "minecraft:spruce_door", "minecraft:birch_door", "minecraft:jungle_door", "minecraft:acacia_door", "minecraft:dark_oak_door", "minecraft:crimson_door", "minecraft:warped_door", "#the_aether:aether_wooden_doors" ] }{ "replace": false, "values": [ "#the_aether:aether_wooden_doors" ] }15:35I still don't see the value in copypasting the vanilla values in; they're already included - C
- C
- C
- S
- C
- C15:46glad its fixed
- S
- C@Jack Papel Alert, Crash earlier on Solly's end:
[16.07 09:53:05] [Server] Caused byjava.lang.IllegalArgumentException: bound must be positive [16.07 09:53:05] [Server] at java.util.Random.nextInt(Random.java:388) ~[?:?] [16.07 09:53:05] [Server] at net.minecraft.class_1303.localvar$zih000$modifyEntry(class_1303.java:553) ~[intermediary-server.jar:?] [16.07 09:53:05] [Server] at net.minecraft.class_1303.method_35051(class_1303.java:248) ~[intermediary-server.jar:?] [16.07 09:53:05] [Server] at net.minecraft.class_1303.method_5694(class_1303.java:236) ~[intermediary-server.jar:?] [16.07 09:53:05] [Server] at net.minecraft.class_1657.method_7341(class_1657.java:620) ~[intermediary-server.jar:?] [16.07 09:53:05] [Server] at net.minecraft.class_1657.method_6007(class_1657.java:597) ~[intermediary-server.jar:?] [16.07 09:53:05] [Server] at net.minecraft.class_1309.method_5773(class_1309.java:2346) ~[intermediary-server.jar:?] [16.07 09:53:05] [Server] at net.minecraft.class_1657.method_5773(class_1657.java:274) ~[intermediary-server.jar:?] [16.07 09:53:05] [Server] at net.minecraft.class_3222.method_14226(class_3222.java:466) ~[intermediary-server.jar:?] [16.07 09:53:05] [Server] ... more15:49Approx. 1 hour ago it seems Just woke up to see logs - S
- C
- J
- C
- J👀mp4Minecraft__1.17.1_-_Singleplayer_2021-07-16_22-14-49.mp4Video, 2.4 MB. Not stored in the archive.21:16My code for this sucks tho, and probably doesn't work on servers, so I'm gonna make it nicer
- J
- A
- J
- A
- J
- A
- J
- C
- A
- CAlso I fixed up https://github.com/devs-immortal/The-Aether/issues/394 The cause was very ez xD22:49Someone stubbed the function
- A
- C22:52Your gonna roll in your grave when you see it
- A
- C
- A
- C
- A
- C
- A
- A23:37@CDAGaming answer me
- C23:38Not genetics stuff tho
- A
- C23:46If conflicts happen, Ill just push the emergency fix then do the main revisions later tonight
- S23:47It's been around for a long time
- A23:48Taking half a heart of damage every once in a while is not exactly the end of the world :3
- C23:49at times over half health or straight death



