mod-dev-talk Saturday 17 July 2021

55 messages4 people

AzzyypaarasTeam00:54
ouch

CDAGamingTeam00:56

Yea, it would have been too major of a change for now

I pushed it though for it to be done at a future date

Gonna push some of the regression fixes in a few though

Along with some new todo entries

pushed!

Notes:
 - Moas will now follow their parents
 - Add World constructors to AnimalEntity and SaddleMountEntity (The IDE complains otherwise)
- Fixes an issue where Baby/Dead Aether Mobs could be saddled
- Added TODOs for canBeControlledByRider and a stubbed travel segment in MountableEntity

CDAGamingTeam01:17

@Azzyypaaras You win a medal.

For crashing the server.

[16.07 20:16:50] [Server] Caused byjava.lang.NullPointerException: Cannot invoke "java.util.UUID.equals(Object)" because "â˜ƒ" is null
[16.07 20:16:50] [Server]     at net.minecraft.class_1924.method_18470(class_1924.java:180) ~[intermediary-server.jar:?]
[16.07 20:16:50] [Server]     at com.aether.entities.passive.MoaEntity.method_35057(MoaEntity.java:442) ~[aether-1.17.1-1.5.0.jar:?]
[16.07 20:16:50] [Server]     at com.aether.entities.passive.MoaEntity$MoaEscapeDangerGoal.method_6264(MoaEntity.java:453) ~[aether-1.17.1-1.5.0.jar:?]
[16.07 20:16:50] [Server]     at net.minecraft.class_4135.method_6264(class_4135.java:22) ~[intermediary-server.jar:?]
[16.07 20:16:50] [Server]     at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:178) ~[?:?]
[16.07 20:16:50] [Server]     at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179) ~[?:?]
[16.07 20:16:50] [Server]     at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179) ~[?:?]
[16.07 20:16:50] [Server]     at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179) ~[?:?]
[16.07 20:16:50] [Server]     at java.util.Iterator.forEachRemaining(Iterator.java:133) ~[?:?]
[16.07 20:16:50] [Server]     at java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801) ~[?:?]
[16.07 20:16:50] [Server]     at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484) ~[?:?]

AzzyypaarasTeam01:17
A
Alright fuck that I am just throwing a feature away
Moas will run away when you abuse them because fuck you
CDAGamingTeam01:18
Server's unable to come up for now, bc if I fix this the wrong way, every moa's gonna go 💥
AzzyypaarasTeam01:18
I know
the
exact
fucking line of code
that is causing this
YOU
wAIT NO
That can't be it
uuuh
hm
CDAGamingTeam01:20
I know why
Bc the existing moas
have no owner id
You need a null check for that situation
AzzyypaarasTeam01:20
Aaahohfuck
CDAGamingTeam01:20
Yup
AzzyypaarasTeam01:20
Remember children
This is why you don't code at 4 AM
CDAGamingTeam01:20
You added all that uuid data, but all the moas on the server have no owner uuid stored xD
SollyTeam01:21
Just yeet all moas
AzzyypaarasTeam01:21
Today I will be unnecessarily sleek
SollyTeam01:21
They're stinky anyway
CDAGamingTeam01:21
Fuck that I like compatibility xD
Plus it kinda fucks over 1.16.5
SollyTeam01:21
DFU when

CDAGamingTeam01:22

Wait Azzy

@Nullable
   public LivingEntity getOwner() {
      try {
         UUID uUID = this.getOwnerUuid();
         return uUID == null ? null : this.world.getPlayerByUuid(uUID);
      } catch (IllegalArgumentException var2) {
         return null;
      }
   }

Just use this

That's how mojang accounted for the null uuid scenario

SollyTeam01:22
var2
AzzyypaarasTeam01:22
Huh
Too late, already made a banger one liner 😎
CDAGamingTeam01:23
O.o
Ok that works too
Push it and ill test
AzzyypaarasTeam01:24
There
Also, if you are doing or planning to do clean up
I spoke about it with jack earlier, but we should reformat our registries
https://discord.com/channels/770691727568404521/770698788629118997/865303927751049216
There is no reason for us to separate variable declaration and initialization, it makes things messy and difficult to maintain
ColdFlame5322:23
AerBunnies on top ya lil bitches (;