mod-dev-talk Monday 14 June 2021

102 messages9 people

Crackers010602:26
hate dealing with mappings man
CDAGamingTeam02:28
You do know I converted it back to yarn xD
https://github.com/devs-immortal/The-Aether/pull/265 I prepared for every scenario, plus I recognized some of those mapping names
Crackers010602:33
thank you jeebus
CDAGamingTeam02:35
Also, in an update tonight on the branch, Swets Darts and Gravitite all work pretty much 1:1 to 1.16.5
The other entities will take more time while toolsets update
Crackers010602:35
do swets sweat?
as in, produce splashing particles constantly?
CDAGamingTeam02:36
And bc the dart shooter was missing sound effects, I decided to use the crossbow shoot sound as a surrogate for the time being as it's close to the original effect
CDAGamingTeam02:36
Replying toCrackers0106as in, produce splashing particles constantly?
They extend slimes, so...yea?
Crackers010602:37
yeah in aether 1.12 they produce water splashing particles so I assumed they would in gg's 1.16 port
CDAGamingTeam02:37
Ah watersplash particles Send me a video and ill try to repduce that
Crackers010602:38
there's images here https://github.com/Gilded-Games/The-Aether-Archived/issues/87
GitHub
Aerwhales, cockatrice, swets and zephyrs do not appear to have a de...
Currently it appears that the ambient/moving subtitle "Swet squishes" is used both for when jumping/landing and when taking damage. Death does have its own subtitle: And slimes do...
oh my god muzikbike
I know him
Jack PapelTeam02:40
I believe our swet particles are the default slimeball textured particles
We could probably have them use the swet ball texture instead(edited)
CDAGamingTeam02:40
It's unmodified from the slime's data, but I can easily change it to the water particles for now
Crackers010602:41
Replying toJack PapelI believe our swet particles are the default slimeball textured particles
they do, yes
CDAGamingTeam02:42
Done! Now using splash particles 😄
Also yes you can too ride on gravitite
no mom, it's not dangerous, I don't need no helmet!
Jack PapelTeam02:43
I'll probably make another big swet-related PR in the near future
Crackers010602:45
I tried seeing what happens when sand falls onto gravitite that's floating into the air earlier, and the result was an unstoppable force hitting an immovable object
fishy02:45
Replying toCDAGamingAlso yes you can too ride on gravitite
but does it work with dimension stack
Crackers010602:45
basically, the sand got destroyed and popped into an item
CDAGamingTeam02:47
Replying tofishybut does it work with dimension stack :thonk:
I don't think so, though I dont wanna strain my pc to find out
Still got some more stuff to do tonight and one more bug sweep
Crackers010602:51
Is FeatureContext not in 1.16.5 or something? I can't find it in my decompiled sources
Not too familiar with 1.17
Jack PapelTeam02:51
Yes
Whatever constructor that's for is just built different in 1.16
CDAGamingTeam02:52
Jack PapelTeam02:52
A bunch of things are combined into FeatureContext instead of being separate variables
Crackers010602:59
too tired to dive into the hell that is worldgen right now, will try tomorrow
Jack PapelTeam03:00
Take a look at other features to see what they use instead of FeatureContext
Or just update your fork to 1.17 and use the new system
Crackers010603:04
seems like it would be easier to just update to 1.17
Jack PapelTeam03:05
You'll need to sooner or later
Crackers010603:05
yeah
CDAGamingTeam03:29
Off he goes to replicate and spread mass havoc
Jack PapelTeam03:31
What do you mean replicate? afaik I haven't implemented any replication mechanic
CDAGamingTeam03:33
There is a bug where the swet's size doesnt fully decrease (It only decreases once)
So the more you kill a swet, you eventually get hundreds of duplicates of the same size and strength
Effectively making the swet unkillable
Jack PapelTeam03:34
It shouldn't decrease at all 😅 It should just die if I did it right
Hopefully this is only a 1.17 thing ?
CDAGamingTeam03:34
I'd check xD
Crackers010604:26
Yeah on my fork it just dies
I never modified the swet behavior
Jack PapelTeam04:46
Phew
AzzyypaarasTeam05:03
Special splitting swet version? 😳
cr24Team05:04
make it a different color
Crackers010612:15
pink swets
SweepSwap15:35
Water swets
Just water colored
Jack PapelTeam15:39
Why did the notification say "Cum Swets"?
Something to explain?
Though I'm on board
SweepSwap15:44
I’m
I’m
Um
😈
Jack PapelTeam15:45
😋
SweepSwap15:45
😥🥵🥵🥵
Jack PapelTeam15:48
Would a swet that has split and is smaller still get the player stuck?

ExistingEevee ⌬15:48

only if it fits the players head

also i went a head a made a fix for the white swet as i need it working for a upcoming smp server for my friends

i thought i might as well share the code here for easy acsess

    public void onPlayerCollision(PlayerEntity player){
        List<StatusEffectInstance> parseableEffects = new ArrayList<StatusEffectInstance>();
        Collection<StatusEffectInstance> effects = player.getStatusEffects();
        parseableEffects.addAll(effects);
        
        for (StatusEffectInstance effect : parseableEffects) {
            this.applyStatusEffect(effect);
            player.removeStatusEffect(effect.getEffectType());
        }
        super.onPlayerCollision(player);
    }

Jack PapelTeam15:52
I'm not sure I understand what the issue with using a collection is. As far as I can tell there isn't any shenanigans happening
SweepSwap15:52
Replying toJack PapelWould a swet that has split and is smaller still get the player stuck?
Like a stepsister?
ExistingEevee ⌬15:52
Replying toJack PapelI'm not sure I understand what the issue with using a collection is. As far as I can…
basically you are reading and editing a collection at the same time
and that causes a ConcurrentModification error
K
kalucky0Team15:52
stepswet 😳
- 🥵1
- 🍆1
Jack PapelTeam15:53
I don't believe I edit the collection
I remove the status effect from the player, not the collection
ExistingEevee ⌬15:53
the collection is linked to the player somehow
i got a crash from this
Jack PapelTeam15:53
Oh that's odd
SweepSwap15:54
So you are fixing something
Cool
😎
ExistingEevee ⌬15:54
ig
this should fix the error and keep the same functionality as you intended originally
CDAGamingTeam16:27
Nice, thanks for the fixes xD
AzzyypaarasTeam19:15
Replying toSweepSwapLike a stepsister?
I have corrupted this server
SweepSwap19:15
no
i already had that humor
AzzyypaarasTeam19:16
banned for speaking back to an admin
Jack PapelTeam19:38
SweepSwap20:01
no
stop
stop
i am bully
Crackers010620:32
hi bully I'm crackers
S
SweepSwap21:09
https://cdn.discordapp.com/emojis/824802402569945168.png?v=1
- 2
Crackers010623:10
I hardly know how to use Github how do I merge the 1.17 branch into my fork so I don't have to do all the porting work myself
CDAGamingTeam23:16
Well the pr I have out is gonna get merged in a few, as it's approved Wanted to play TABS first to relax a bit beforehand though To merge the branch, most git clients actually can do that so long as you have our branch as a remote
Crackers010623:51
Wonder if the github desktop app can do that
Jack PapelTeam23:52
Github desktop app is useful, I recommend
cr24Team23:53
Very handy