mod-dev-talk Sunday 13 June 2021

371 messages10 people

KyrptonaughtTeam00:00
Interesting, It's marked as static in my mixin, and in BucketItem.class
KyrptonaughtTeam00:00
Replying tonailujwhy isnt it https
I applied for an ssl cert from my host but they haven't responded. Been 2 weeks now
CDAGamingTeam00:01
I did see this error before when I was testing the 1.17 branch on jitpack as well a few days back, but it's weird for it to fail like that(edited)
nailuj00:03
Replying toKyrptonaughtI applied for an ssl cert from my host but they haven't responded. Been 2 weeks now
do you have ssh access to the server?
you can set up let's encrypt if you do
KyrptonaughtTeam00:04
Well my domain is just a redirect to an aws bucket
nailuj00:04
oh
then you can easily set up let's encrypt
KyrptonaughtTeam00:04
How so?
nailuj00:05
i assume you have ssh, right
because it is an aws thing
idk much about aws
KyrptonaughtTeam00:05
I think an s3 bucket is just static
nailuj00:05
oh
then idk how
i thought bucket in aws terminology was server
KyrptonaughtTeam00:07
I do have a cloud server as well though, but I was planning on getting rid of it and re purposing the bucket for hosting
CDAGamingTeam00:08
Well, in terms of the bucket issue, I'm gonna be up for awhile so I'm down to test any potential fixes, but I'll stub the code again for now so I can continue with testing
KyrptonaughtTeam00:09
Replying toCDAGamingWell, in terms of the bucket issue, I'm gonna be up for awhile so I'm down to test any…
I'm experimenting, doesn't seem to be an issue in cpa dev environment(using a replica aether style portal). Must be something going on in aether. I'll clone the repo
I'm guessing maybe the skyroot bucket?
CDAGamingTeam00:10
Maybe, though the code is almost entirely the same as it had been before
KyrptonaughtTeam00:10
1.17 thing maybe
CDAGamingTeam00:11
Maybe, though it doesnt signal what exactly is changed
KyrptonaughtTeam00:20
No issue at all on my end.
I cloned the 1.17 branch and re enabled the portals
My guess is some funky gradle magic
CDAGamingTeam00:26
Huh your right, somehow maybe jitpack isnt getting your branch's newest commit
KyrptonaughtTeam00:29
Oh are you not using my maven?
CDAGamingTeam00:30
I'm gonna use it now to see if that works, and see if it's jitpack just being dumb xD(edited)
Yup that worked, screenshot coming shortly xD
Works!
Oddly enough though immersive portals doesn't seem to work with it, though idk if that's an issue on our end or yours
cr24Team00:37
have you tried going through the portal a few times and reloading the world
CDAGamingTeam00:38
Normally, IP auto loads chunks as soon as the portal is created
cr24Team00:38
it didn't before
CDAGamingTeam00:39
Comes up with this immediatly after portal activation
cr24Team00:39
for nether portals it does
aether portal was always a bit finicky
CDAGamingTeam00:40
Ah there we go
I had to go back through, but the thing is this was an exit portal so it should have already known of the chunks
cr24Team00:41
its weird but it works eventually
CDAGamingTeam00:41
This is even stranger
AzzyypaarasTeam00:41
Replying toCDAGamingAh there we go
This gives me an idea for a promotional image
CDAGamingTeam00:41
That portal down there was the original exit portal xD
AzzyypaarasTeam00:41
Make a massive portal and set it up so the screen is split half-half
CDAGamingTeam00:42
Alrighty
How big
AzzyypaarasTeam00:42
With glowstone going down the middle
Enough that you can't see the edge of it, you should just see the aether, overworld, and a line of glowstone going down the middle
Throw iris on top and you have something that would look splendid on the CF page
CDAGamingTeam00:44
Uh oh
LudoCrypt00:44
O.O
cr24Team00:44
rip
CDAGamingTeam00:44
Does it not support custom portal sizes
smh
LudoCrypt00:44
CDAGamingTeam00:46
Oh i know why
It's unironically an issue intentionally done our our end
LudoCrypt00:46
O.O
KyrptonaughtTeam00:46
Aether has the size of the portal locked(edited)
CDAGamingTeam00:47
Not anymore 😄
I wonder who did that in the first place though
KyrptonaughtTeam00:47
Proper IP support will be coming eventually btw
CDAGamingTeam00:48
Ooh, nice 😄
LudoCrypt00:48
😳(edited)
KyrptonaughtTeam00:48
think it was kalucky, I'm pretty sure he was the one who asked me to implement it in cpa
CDAGamingTeam00:48
I'd ping him, but he's asleep atm xD I'll roast him when he wakes up
AzzyypaarasTeam00:49
please do
What a sinful thing it is to prevent people from making obscenely large portals
CDAGamingTeam00:49
Huh, that's odd...
AzzyypaarasTeam00:49
@Kyrptonaught is there an upper cap on portal size?
CDAGamingTeam00:49
Trying to make the portal without the limit, breaks the portal instantly
AzzyypaarasTeam00:49
CDAGamingTeam00:49
Like it creates, but then does the glass effect and insta-shatters
Seemingly, it's trying to both place water and activate the portal (As when the portal is able to activate, water is also placing)
What would be the call to make these portal blocks non-tangable?
KyrptonaughtTeam00:52
Replying toAzzyypaaras@Kyrptonaught is there an upper cap on portal size?
Mimics vanilla, don't recall offhand
CDAGamingTeam00:53
Is there an upper limit 😏 *inb4 making height limit portal
What a great view!
LudoCrypt00:54
O.o
KyrptonaughtTeam00:54
Replying toKyrptonaughtMimics vanilla, don't recall offhand
21
LudoCrypt00:54
uhm
thats not right
CDAGamingTeam00:55
I just noticed that, its because the exit portal isnt the same size
Jack PapelTeam00:55
Pixel consistency is unbased
LudoCrypt00:55
scale is fucked
CDAGamingTeam00:55
So IP is having trouble calculating that
Yup
KyrptonaughtTeam00:57
Replying toCDAGamingSeemingly, it's trying to both place water and activate the portal (As when the portal…
Investigating
CDAGamingTeam00:57
Alrighty, also @Azzyypaaras is this what your looking for
In terms of the view, ik i have to go higher on the y axis for a better aether view xD(edited)
AzzyypaarasTeam00:58
Almost
Make it so you can see both the overworld and the aether
let me...
CDAGamingTeam00:59
Ah I see, ok gimme a bit
Also with a larger portal, each portal block is generating water drip particles when they shouldnt
I broke IP xD
IT flat out said no to a portal that big xD
LudoCrypt01:06
use global portals
AzzyypaarasTeam01:07
holy idea
do the world roof protal things
LudoCrypt01:07
do it
AzzyypaarasTeam01:07
hook up the overworld and aether
CDAGamingTeam01:08
Wait, what exactly do you want me to do?
LudoCrypt01:08
make the aether and the overworld connected
i did that in the garden with my two dimensions
CDAGamingTeam01:08
Just normal portals?
LudoCrypt01:08
global portals
CDAGamingTeam01:09
Send the link to the mod
AzzyypaarasTeam01:09
https://github.com/qouteall/ImmersivePortalsMod/wiki/Dimension-Stack
GitHub
qouteall/ImmersivePortalsMod
Non-Euclidean in Minecraft. Contribute to qouteall/ImmersivePortalsMod development by creating an account on GitHub.
It is Immersive Portals
Scroll to the bottom of the page to see how to do it with commands
CDAGamingTeam01:09
O.o
LudoCrypt01:10
i did it in code here https://github.com/LudoCrypt/The-Garden/blob/main/src/main/java/net/ludocrypt/the_garden/compat/impl/GardenImmersivePortalsCompat.java#L44-L46
CDAGamingTeam01:10
Gonna get food real quick, one sec
fishy01:10
dimension stack with the aether prevents the falling from the aether advancement, fyi
KyrptonaughtTeam01:14
Replying toCDAGamingSeemingly, it's trying to both place water and activate the portal (As when the portal…
beta33 was uploaded and fixes this
CDAGamingTeam01:15
Sweet xD
nailuj01:34
Replying toCDAGamingI broke IP xD
solution: portals generate the same size in the aether
that would be pretty useful actually
nether portals should be like that too
CDAGamingTeam01:35
It works, but the Aether is so high up that you cant even see the ground
Ah nvm
It just took ages to actually re-generate it since I upped render distance to 32
nailuj01:38
Replying toCDAGamingIt just took ages to actually re-generate it since I upped render distance to 32
i feel bad for your poor gpu
my discrete GPU cant even handle that
FoundationGames01:38
dimension stack?
that is actually really neat i oughta try that
CDAGamingTeam01:39
Ah no wonder its so slow
this isnt on my gpu
It's using my cpu
cr24Team01:40
oof
CDAGamingTeam01:40
But I can get a good screenshot
@Azzyypaaras
fishy01:41
what about from the overworld (edited)
AzzyypaarasTeam01:41
Glory
Now add iris
CDAGamingTeam01:42
My poor cpu
I'm gonna have to move rendering to my gpu for the rest of this xD
fishy01:43
iris on a cpu would be pain
CDAGamingTeam01:44
Never try to save a stacked world xD
Is there even an iris version supporting 1.17?
I see https://github.com/IrisShaders/Iris/releases/tag/1.0.0 but idk if thats gonna support 1.17

CDAGamingTeam01:59

Caused by: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: @At("INVOKE") on net/minecraft/class_281::iris$allowSkippingMojImportDirectives with priority 1000 cannot inject into net/minecraft/class_281::method_34416(Lnet/minecraft/class_281$class_282;Ljava/lang/String;Ljava/io/InputStream;Ljava/lang/String;Lnet/minecraft/class_5913;)I merged by qouteall.imm_ptl.core.mixin.client.render.shader.MixinProgram with priority 1200 [PREINJECT Applicator Phase -> mixins.iris.json:MixinGlShader -> Prepare Injections ->  -> redirect$zjc000$iris$allowSkippingMojImportDirectives(Lnet/minecraft/class_5913;Ljava/lang/String;)Ljava/util/List; -> Prepare]

What on earth is this xD

Plan B

CDAGamingTeam02:07
Ah, I see, apparently immersive portals is incompatible with BOTH Iris and optifine
So uh, @Azzyypaaras you aren't getting shaders fam
At least not until probably Sept - October
AzzyypaarasTeam02:08
CDAGamingTeam02:08
Hopefully the two other screenshots are the intended effect xD
Crackers010604:13
@CDAGaming Got distracted playing with Iris, will take those screenshots now
LMAO
cr24Team04:16
bruh
lol
Crackers010604:19
I placed the water in the portal and the portal lit and then immediately broke with water flowing out
CDAGamingTeam04:25
Replying toCrackers0106I placed the water in the portal and the portal lit and then immediately broke with…
The newer portal api version fixed that
I have it stored on my local fork, as I'm working on something potentially bigger then 1.17, whilst still involving it and polishing 1.17s current progress
Crackers010604:26
https://github.com/devs-immortal/The-Aether/issues/245
GitHub
Aerclouds produce shadows · Issue #245 · devs-immortal/The-Aether
In both the official versions of the Aether by Gilded Games, aerclouds are transparent blocks like glass and do not produce shadows. However in Aether Reborn they do produce block shadows causing l...
I updated the issue
CDAGamingTeam04:27
Replying toCrackers0106I updated the issue
https://github.com/CDAGaming/The-Aether/tree/big-bang-theory Test with this (I'm planning to backport a lot of the fixes made today to 1.17/1.16.5 later next week)
Also, ah moody brightness, that's what i was missing!
Crackers010604:28
I suppose I should use the last working commit as all the recent ones failed Github Actions?
CDAGamingTeam04:29
The actions fail due to the webhook url, the builds themselves are all compilable
Crackers010604:40
@CDAGaming still there in that build
CDAGamingTeam04:49
OOF, ill try to fix it tomorrow
I've also published the summary of the branch I've been working on here: https://github.com/devs-immortal/The-Aether/pull/260 It is not planned to be merged until a unanimous decision is made over it once it is completed, but I'm putting together the draft to put together what it's about(edited)
GitHub
[Draft] The Big Bang Theory by CDAGaming · Pull Request #260 · devs...
This PR has been constructed under an effort to aid GG in their port to 1.16/1.17, with the results being beneficial to both ports. What this PR does Maps the entire project to mojmaps, to serve a...
Crackers010604:52
Also, an experiment I did. Here's a location on Aether 1.12.2, and the same location with the same seed on Aether Reborn (BBT branch)
CDAGamingTeam04:55
That's mostly as the noise generation is vastly different (Originally I wanted to convert the in-code 1.14-era chunkgenerator to the noise files, but the effort eventually failed due to a lot of the code being illegible) I'd still be down though to check it out if you happen to find a way at doing that @Crackers0106(edited)
Crackers010604:56
>(Originally I wanted to convert the chunkgenerator to the noise files, but the effort eventually failed due to a lot of the code being illegible) Ugh, yeah, that's what I tried to do once
said fuck it and used GG's Forge 1.16 port's noise settings instead
I had the same problem as you
I couldn't read it for shit
CDAGamingTeam04:57
The old generator is primarily from the 1.13 ports, and was migrated by a less-experienced me to 1.14.4 1.15.x could still handle it, but 1.16 snapshots finally broke it royally(edited)
Crackers010604:58
Yeah I wanna see how close I can get to the original 1.12 generation with the json noise settings
I'm doing gameplay stuff right now first though before I dive straight back into the pain that is world gen
My more accurate port of Aether I is pretty much just stripping away all the stuff Aether Reborn adds btw lol
Once I replace some old GG assets with my own I'll update my git repo
CDAGamingTeam05:03
I can tell, and that's fair. Originally, this project was aimed to be like that, but things shifted forward quickly once popularity for the project rose. In honestly, I consider reborn to be a 1.5 revision in the timeline lore-wise (After the initial sun spirit defeat, but before the rest of the time skip and whatever happened to cause a much bigger expansion to the land)(edited)
Crackers010605:03
Also found a crash in your fork, I tried powering a Gravitite Levitator and the game froze and crashed
CDAGamingTeam05:04
Does it crash in the normal 1.17 port?(edited)
Crackers010605:04
Crackers010605:04
Replying toCDAGamingDoes it crash in the normal 1.17 port?
I haven't checked
Was just messing around and decided to try powering one
Those are the AR equivalent to Enchanted Gravitite right?
CDAGamingTeam05:05
Also oddly enough those setBlock warnings are pretty much the equivalent of cascading worldgen lag warnings from 1.12.2 No idea why they were silent before
CDAGamingTeam05:06
Replying toCrackers0106Those are the AR equivalent to Enchanted Gravitite right?
I want to say yes, but I don't want to be wrong, since I didn't make that xD
Crackers010605:06
Might want to look into readding that block into my fork then and renaming it and removing the existing gravitite block in favor of it
Looks like it is
CDAGamingTeam05:08
I would definitly check if the main 1.17 port has the same crash though, since it helps tell me if it's an issue from the main branch, or something I messed up in the draft so i know where to fix it mainly 😄(edited)
Crackers010605:47
pain
Jack PapelTeam05:48
Probably the best UV texture I've ever seen
Two whole wasted rows at the bottom for no reason ?
Crackers010605:55
yeah this is what the full thing looks like
CDAGamingTeam05:57
I believe I found the shadow issue, mostly just improper rendering layers when compared to vanilla
Crackers010606:54
https://paste.ee/p/MlWN9
Paste.ee
View Paste MlWN9
Paste.ee - View Paste MlWN9
yet another crash https://paste.ee/p/buF36
Paste.ee
View Paste buF36
Paste.ee - View Paste buF36
this time with flying cows
Jack PapelTeam06:59
First one sounds like a missing null check
CDAGamingTeam07:02
FloatingBlockEntity ALSO counts as an entity @Crackers0106
Crackers010607:03
yes
CDAGamingTeam07:03
So the first crash is invalidated, from the fact i mentioned earlier that none of the entities models are in the 1.17 port xD
Crackers010607:03
o h
CDAGamingTeam07:04
Second one seems to be the same thing, but an unmapped version of it
Crackers010613:17
As a placeholder for the Altar's function, I've made some things it can do work in furnaces and blast furnaces instead
I'll also make ambrosium a valid fuel source for them too since coal cannot be obtained in the Aether
I've also changed the textures of Moas, Flying Cows, Phygs, and Swets
The moa texture is unfinished, but most of it is there
I've also fixed a bug where skyroot and golden oak leaves were dropping regular sticks instead of skyroot ones, and removed blocks of gravitite and readded the gravitite levitator, though renamed to enchanted gravitite and gravitite tools and armor are now crafted with it. It uses the same texture gravitite blocks did
Next I need to add viens of aether dirt and icestone, make swets sweat, and fix golden oak leaves particles using the old falling leaf texture instead of the generic dust one(edited)
then fix the floating flying cow and phyg wings, and also fix the damn durability bug
I want to also reimplement the way blueberry bushes used to work in AR like they did in the original(edited)
speaking of blueberry bushes, I saw a aerbunny eat the berries off of one, and I thought that was very cute
CDAGamingTeam16:55
So update on the aerclouds: Tried until 3am to work at fixing it, couldn't figure it out even though in my branch they are now 1:1 with GG's version
I honestly have no clue how the shadows are occuring
Crackers010616:57
does the bug occur in the GG version? 🤔
CDAGamingTeam16:58
It doesnt
Crackers010616:58
You might want to look at how quicksoil glass removes shadows
CDAGamingTeam16:58
The constructor, renderlayer, and json data are all the exact same on both theirs and my branch atm, but no change with the shadows
Crackers010617:00
On my fork, I still can't find the cause of the durability bug and I'm about to just rewrite the tools entirely
CDAGamingTeam17:00
Does it only occur on your fork?
Crackers010617:01
Haven't tested
Check if Zanite tools have only 59 durability
Every stat besides that is fine
CDAGamingTeam17:21
Alrighty, though in the meantime, see if you can find a diff in the Aerclouds that may be causing the shadow As it being 1:1 but still being broken is severely annoying xD
250 durability
Crackers010617:26
It's probably a bug with the holystone and skyroot tools then
CDAGamingTeam17:28
Ah those were disabled due to not adding anything to the experience and being 1:1 to wood/stone
Crackers010617:30
Yeah
I enabled them for accuracy reasons
I need to check in a bit if they did that in the versions they existed in
Crackers010618:32
it works normally in the latest alpha build
CDAGamingTeam18:43
Aerclouds or durability?
cr24Team18:44
he re-enabled holystone and skyroot tools
CDAGamingTeam18:44
Ah, well up to the rest of the team if we want to re-add them back in then
Also at this point, the only thing that I feel could be wrong about the aerclouds is the texture being too dark for the game to handle purely with translucency
Crackers010618:49
Replying toCrackers0106it works normally in the latest alpha build
correction: the first beta it works on, not alpha
Crackers010618:50
Replying toCDAGamingAlso at this point, the only thing that I feel could be wrong about the aerclouds is the…
I doubt it's the texture, I have a pack that changes all the textures to their classic versions and they still produce shadows with it on
CDAGamingTeam18:50
Then I truly don't know whats causing it...
Crackers010618:50
this is on beta v1.0.0, works fine here
and I see no differences between the latest dec 13th commit and my fork
I'll just rewrite the damn thing
CDAGamingTeam18:58
So i did a test
Seemingly it's only the generated aerclouds causing shadows. User-placed ones seemingly aren't casting any shadows
Crackers010618:59
ah so it's fucking lighting engine jank
wonderful
CDAGamingTeam18:59
Maybe, but if the GG version isn't breaking it's something on our end still
And It's gonna drive me insane until I can patch it
Crackers010619:00
I remember making a huge block of aerclouds by hand to see if placed ones did it and they did
CDAGamingTeam19:01
🤔
CDAGamingTeam20:00
@Crackers0106 https://github.com/devs-immortal/The-Aether/pull/260/commits/20787b7114791550469b053dffc3cce7e3976d95 Enjoy 😄
Jack PapelTeam20:22
Speaking of clouds
Our clouds seem idk, off
GG's clouds are lovely but ours seem lumbering and unwieldly
the generation that is
AzzyypaarasTeam20:25
That would be because we suck at cloudmaking
Have we had a single good iteration?
CDAGamingTeam20:25
Well, from the commit I just pushed to the draft, I added a genType as I figured this scenario might occur, though Crackers was the inspiration for it Basically, both the modern and legacy generation for quicksoil, clouds, and lakes are in and perfected 1:1
Jack PapelTeam20:25
I think it's too obvious they're made of cylinderoids
Oh nice
CDAGamingTeam20:26
^^ True, plus the shadow issue
AzzyypaarasTeam20:26
Solution: metaspheres
CDAGamingTeam20:26
Apparently it's caused from an improper material being used, but I don't know the first thing of custom materials
AzzyypaarasTeam20:26
Aaaah fuck
Jack PapelTeam20:26
AzzyypaarasTeam20:26
Like, the block material?
Jack PapelTeam20:26
?
CDAGamingTeam20:26
Yup
AzzyypaarasTeam20:26
Yes, those metaspheres
I'll work on it
Metaspheres are the answer to everything
CDAGamingTeam20:27
In the constructor, both snow and ICE as the material were wrong when I spoke to Haven earlier
AzzyypaarasTeam20:27
Only one problem: I don't know how to metasphere
Jack PapelTeam20:27
Don't metaspheres entail some sort of marching?
Or maybe not
Seems computationally intensive tho
CDAGamingTeam20:27
Yet it makes it even more confusing bc GG's impl works fine AND uses ice
AzzyypaarasTeam20:28
They really do be on us
CDAGamingTeam20:28
I mean some of the pr changes are gonna quickly catch up to them xD
Jack PapelTeam20:28
I think metaspheres will also seem too artificial but if you want to give it a try go ahead(edited)
AzzyypaarasTeam20:28
Metaspheres may be a good solution if used smartly
CDAGamingTeam20:28
I already got terrain able to work on both sides of the coin 😄 Not only that but being able to switch the blockStates on the three features mentioned earlier
AzzyypaarasTeam20:29
They are a common way to do clouds in more typical 3d games
CDAGamingTeam20:29
IE if you wanted to, as a silly gimmick, you can change the json to have every quicksoil patch have blue aercloud instead and make a bouncy world
AzzyypaarasTeam20:29
So I don't see why we can't try
Jack PapelTeam20:29
Sure give it a shot
CDAGamingTeam20:30
And for genType, it allows better support for if we ever wanted to do say amplified terrain gen
Jack PapelTeam20:30
Maybe I'll look into some noise thing as well
AzzyypaarasTeam20:30
This example is for blender, but it shows well them being used in clouds
'ight
...
fuck now I need to figure out how they work
Jack PapelTeam20:30
That looks nice
AzzyypaarasTeam20:31
Stack exchange come save my ass!
CDAGamingTeam20:31
hehehe
AzzyypaarasTeam20:31
I feel like I am about to be happy about taking precalc instead of college algebra soon
Jack PapelTeam20:31
I think it'll look best if the clouds aren't so large, such that that cloud shape for example would only cover like two dozen blocks(edited)
Oh calc is fun
If you aren't learning it in a class
But still fun
AzzyypaarasTeam20:33
hmph
CDAGamingTeam20:33
HOW THE HELL
Somehow, this is fixed.
AzzyypaarasTeam20:34
lmao
CDAGamingTeam20:34
I didn't even change it, what?!
AzzyypaarasTeam20:34
Also
Jack PapelTeam20:34
Replying toAzzyypaarashmph
Don't worry about the intensity, Minecraft has a fast inverse square root function in math helper
AzzyypaarasTeam20:34
I haven ow been reminded for the 20 billionth time that I need to redo the advancements
AzzyypaarasTeam20:34
Replying toJack PapelDon't worry about the intensity, Minecraft has a fast inverse square root function in…
CDAGamingTeam20:34
Oh yeah, I planned to touch on that soon
AzzyypaarasTeam20:34
Like
It... It's beautiful
What is this? This is awful
CDAGamingTeam20:34
Atm, my focus is on improving generation and tagging the hell out of everything
AzzyypaarasTeam20:35
Mind you, I am only planning to tackle them from a writing and what you get them for standpoint
So uh, you may still want to look over them afterwards
CDAGamingTeam20:36
Im gonna do a test with the changes I made so far, one sec
Here's the control, using current gen
I'm going to see what it looks like if I use "genType": "legacy" on quicksoil and aerclouds and see how different it is
Under the same seed, same angle, and same positioning
CDAGamingTeam20:45
Very intresting
Crackers010620:46
oh my goodness
I'm bookmarking that for reference later(edited)

CDAGamingTeam20:47

boolean doesProtrude = (
                (reader.getBlockState(pos.west(3)).isAir() ||
                        reader.getBlockState(pos.north(3)).isAir() ||
                        reader.getBlockState(pos.south(3)).isAir() ||
                        reader.getBlockState(pos.east(3)).isAir()) &&
                        (reader.getBlockState(pos).is(AetherBlocks.HOLYSTONE) ||
                                reader.getBlockState(pos).is(AetherBlocks.AETHER_DIRT))
        );

Seemingly though the newer generation doesn't allow for legacy quicksoil to generate, since this condition seems to be continuously false

I wish there was a command to locate any blocks

Crackers010620:48
Replying toAzzyypaarasLike It... It's beautiful What is this? This is awful
lol yeah, I just renamed them to their old names
idk if it's possible to get the "when phygs fly" advancement to work, since I'm not sure if I can get it to check if you've interacted with a phyg wearing a saddle
CDAGamingTeam20:50
There is in the backend, and it would be dumb if mojang didnt have that conditional on the data-driven side
CDAGamingTeam21:05
Replying toCrackers0106I'm bookmarking that for reference later
Does this remind you of anything? 😉
Crackers010621:05
yes
exactly why I bookmarked it lol(edited)
CDAGamingTeam21:06
Specifically, the terrain
This is a new screenshot.
Crackers010621:06
oml
you're remaking the old world gen aren't you?
CDAGamingTeam21:07
If I'm remastering the generation to support the past and present, ofc im gonna take it all the way to see how far the dynamic class can go
In the PR, it's gonna stay the modern gen, but the product of this is that I'll have a dynamic datapack that can be shipped with future versions of the Aether for users who want the classic experience (This will only apply to the datapack, users are on their own if they want the OG assets bc licensing, but the generation itself should be enough to satisfy both sides of the coin)(edited)
Crackers010621:09
yeah one of the first things I noticed in that screenshot was that highlands biomes usually aren't that big in AR's generation
CDAGamingTeam21:09
The other reason, is bc of phase 2 on the draft pr, which is attempting a Forge Port in under 24 hours with how many changes made to reduce the class/method/field diffs(edited)
AzzyypaarasTeam21:10
I must applaud you and your efforts
The other reason, is bc of phase 2 on the draft pr, which is attempting a Forge Port in under 24 hours with how many changes made to reduce the class/method/field diffs
Pardon?
CDAGamingTeam21:10
Bc of the mojmaps, and how much stuff I migrated from FAPI to how mojang does it, I'm almost certain a 1.17 port to Forge can be done in a seperate branch in under a day
Hell maybe even half a day
AzzyypaarasTeam21:11
CDA
Crackers010621:11
Literally I don't have to do any of the world gen work in my fork anymore now that most of it is done for me lol
CDAGamingTeam21:11
The forge port isn't being pr'd, we're still staying on Fabric Azzy, don't worry
AzzyypaarasTeam21:11
I am going to say this once, but I want to make it abundantly clear that I will not put of my or the team's resources into supporting a forge codebase, if you do port you are on your own.
CDAGamingTeam21:11
I'm fully aware and ok with that xD
Crackers010621:12
Now that I've replaced all of the GG assets, I've finally pushed all my changes in my fork to GitHub https://github.com/Crackers0106/The-Aether
CDAGamingTeam21:12
The drafted PR was ideas to experiment with, so ofc I'm not gonna have it cost team resources. (It's why again this is being done as a PR solely by me, instead of it being pushed to the main remote)(edited)
Crackers010621:13
or at least I hope I got all the assets replaced
I have a personal pack I use to replace all the textures with their classic version because I can't stand the modern textures for some reason
AzzyypaarasTeam21:14
Replying toCrackers0106or at least I hope I got all the assets replaced
I mean it is not like you are just going to get instantly sued, GG is not a team of assholes
Crackers010621:14
yeah
AzzyypaarasTeam21:14
If a few things slipped by you are at most just going to get a "hey"
Jack PapelTeam21:15
I mean, we shouldn't speak on behalf of GG but yeah they won't instantly sue or anything
Crackers010621:15
oh my lord I just realized I forgot to remove the music files
A
AzzyypaarasTeam21:15
Not speaking for them, just making a statement based on my observations
- 👌1
CDAGamingTeam21:16
Indeed, GG aren't ones to immediately go into panic mode unless they have due cause to do so (I only speak from prior experiences, not for them)(edited)
Crackers010621:17
I had the old aether music in there because at one point I was trying to see if I could get 4 tracks to have a chance to play in one biome
it never worked so I just kinda forgot I added them lol
AzzyypaarasTeam21:17
Did you manage it?
h
CDAGamingTeam21:17
Which the only instance I have is when I got too excited over the Aether a few years ago, and was not only distributing but hosting a server with the 1.14 archive with their assets, so they had a lot of reasons to step in there(edited)
AzzyypaarasTeam21:17
🤔
CDAGamingTeam21:18
I learned my lesson on that very quickly when they stepped in, since at the time, I didn't realize the assets didnt contain the same license as the code