mod-dev-talk Tuesday 15 June 2021

53 messages4 people

CDAGamingTeam00:05
I personally use GitKraken
Crackers010600:18
ok I am doing things
I doubt this will work the first time because I just now merged it and I will need to fix things
Crackers010601:07
hmm I have no idea how I will add the legacy aercloud gen to my fork since I'm not using the dynamic configuration
CDAGamingTeam01:12
It's just a variable if your using data driven stuff (Which if your on 1.16+, you should be in a data-driven format for the aerclouds)(edited)
Though if you want me example, here's the datapack i made
AetherLegacyGen.zipArchive, 4 KB. Not stored in the archive.
It enables the legacy data on all features supporting the dynamic type
Jack PapelTeam01:14
since I'm not using the dynamic configuration
CDAGamingTeam01:14
You don't technically need to As long as your on the supported commit, it's a drag and drop in-game
I made it as a normal data pack
No backend change needed as long as your fork is based on the current 1.17 branch
Jack PapelTeam01:16
I think they're saying their fork's cloud gen won't be based off the 1.17 branch
CDAGamingTeam01:16
Ah, then yea they are on their own for that unfortunatly
Jack PapelTeam01:16
In which case they should replace the method that generates clouds with CDA's legacy method(edited)
CDAGamingTeam01:17
In the backend for the 1.17 branch, each feature that supports genType has different methods for each (So for Aerclouds, I have a method that generates the clouds in a modern fashion, and a legacy method that's been rebased to work on 1.17)
https://github.com/devs-immortal/The-Aether/blob/1.17/src/main/java/com/aether/world/feature/AercloudFeature.java
L48-L75
Crackers010601:19
So I could just edit the built-in datapack to use it then?
knowing that before would have saved a lot of time
CDAGamingTeam01:19
Pretty much, but as said, you need to be based on the newest 1.17 commit, otherwise it'll consider genType an invalid key
So as long as you are, the datapack will work via drag and drop in the ingame menu
Crackers010601:20
Yes, I merged the newest 1.17 branch into my fork
CDAGamingTeam01:20
Then your good to use it as a normal data pack in-game 😄
CDAGamingTeam02:55
😭
I wish i didnt find this bug
Apparently FloatingBlocks are rapidly swapping between their actual state and the default state
cr24Team02:56
???
CDAGamingTeam02:58
Normally, when you right click a block, it turns it into a FBE and makes it fly up
This IS working, but the blockstate it appears as it being stuck on gravitite ore (It's default)(edited)
And there's at least a dozen different areas that could be the issue which I gotta debug and uncover
Crackers010603:05
I fucking got it to compile
CDAGamingTeam03:08
Apparently there are two block entities somehow being initialized, weird
Init 3 is the correct constructor, Init 1 is the default constructor
Crackers010603:14
oh fucking great
CDAGamingTeam03:15
Yea, the tag systems were rewritten in the data-pack
Mostly just splitting the items into different sub-groups to have them be more maintainable
Crackers010603:16
time to remove all the blocks I don't need yet again
CDAGamingTeam04:49
Ironically these last few days, it isn't adding stuff slowing me down, no it's me digging through the rabbit hole for obscure issues I keep locating xD
And atm, this gravitite issue sure is eluding me xD
CDAGamingTeam05:14
Nvm, my sleep-deprived self didn't double-check my own optimizations xD Was missing a critical method
Crackers010615:24
Are entity models working in the 1.17 branch?
Or are they still broken?
cr24Team15:59
broke
CDAGamingTeam16:12
The good thing is the only things still broke are models and stubbed code
Everything else Ive taken care of as well as major refactors across the board xD
Crackers010623:38
So in my fork when I entered the Aether the game crashed... https://paste.ee/p/1Sc67
Paste.ee
View Paste 1Sc67
Paste.ee - View Paste 1Sc67
I thought I had mob spawning off but apparently not
so it's probably just the entity crash
ok I re-created the world and despite mob spawning clearly being turned off some cows spawned
CDAGamingTeam23:42
java.lang.NullPointerException: Cannot invoke "net.minecraft.class_897.method_3933(net.minecraft.class_1297, net.minecraft.class_4604, double, double, double)" because "â˜ƒ" is null Correct, this is an entity npe
Crackers010623:43
but why the fuck are mobs spawning in the overworld!?
the game reports that mob spawning is off despite the fact that it clearly isn't
CDAGamingTeam23:50
¯\_(ツ)_/¯