Sinytra Connector Support? (1.20 / 1.20.1)

seb "vey" f. · 2024-08-18T21:52:55.278Z

Hey! I know the 1.20 version just released, but I've attempted to use this mod alongside Sinytra Connector because of an idea I had - but for some reason this mod crashes on start. I'm just wondering if you guys ever plan to do Sinytra Connector support at one point? Log: https://mclo.gs/EzVale4 (no crash log for some reason...?)

Paradise Lost

Started by seb "vey" f.18 August 202450 replies

18 August 2024
seb "vey" f.21:52
Hey! I know the 1.20 version just released, but I've attempted to use this mod alongside Sinytra Connector because of an idea I had - but for some reason this mod crashes on start. I'm just wondering if you guys ever plan to do Sinytra Connector support at one point? Log: https://mclo.gs/EzVale4 (no crash log for some reason...?)
mclo.gs
Forge 1.20.1 Client Log [#EzVale4]
100 lines
cr24Team22:22
Oh strange, this looks like a mixin failure for the portal API we use?
cr24Team22:33
@Kyrptonaught not to throw this onto you, but any ideas? I don't see that mixin signature on the error it's throwing, looks like different mappings but no boolean or portalinfo-like path from what I can tell.
I'd like to have PL work on Sinytra Connector but I haven't really worked with it and I'm not sure how I'd really go about debugging anything with it either so it might not be supported (yet at least)
S
seb "vey" f.22:36
ah dang, good to know tho!
22:37
(i just kinda wanted to use this mod with sinytra becuz i prefer this mod aesthetically than OG aether lol)(edited)
- ❤️1
cr24Team22:38
seems to point at: https://github.com/kyrptonaught/customportalapi/blob/1.20/src/main/java/net/kyrptonaught/customportalapi/mixin/EntityMixin.java#L103
GitHub
customportalapi/src/main/java/net/kyrptonaught/customportalapi/mixi...
Developer Api for creating custom portals to any dimension - kyrptonaught/customportalapi
KyrptonaughtTeam22:38
I’m guessing forge changes that method and removes where I’m trying to target? The mixin is to prevent an end portal from spawning when you teleport to the end with a custom portal
Yep
cr24Team22:38
ah okay I figured
KyrptonaughtTeam22:38
Doesn’t help much now, but that mixin is no longer necessary in 1.21 and has been removed(edited)
cr24Team22:39
ah okay that actually might be good news, @seb "vey" f. I'll be updating PL to 1.20.2 soon and if you could try the mod on those versions we can see if it'll work
but that doesn't really help you right now lol
seb "vey" f.22:39
alrighto
👍
KyrptonaughtTeam22:41
I apologize, I meant 1.21
seb "vey" f.22:41
oh lol
KyrptonaughtTeam22:42
That mixin isn’t necessary, especially for pl. We can try marking it as optional and seeing if we get farther(edited)
cr24Team22:55
Sure, anything youve got I am happy to help try if I can
Would it be a bad idea for me to try making a custom CPA version just for PL?
at least, for 1.20.x
KyrptonaughtTeam22:58
I’ll be away for a bit, but you can try in the mean time. If it works I can merge it and make a release
Mark that mixin as optional, increment the version, and then build a jar and throw it in your mods folder and see if it works
19 August 2024
cr24Team01:07
(top left)
KyrptonaughtTeam01:10
Is that all it took?
cr24Team01:11
yep, and removing an unused dependency on the PL side but just that one mixin from CPA
Opened a PR to CPA's 1.20 branch with version 64.5 but I'm not sure what version you actually want it to be
ah wait I forgot to add it to the mod.mixins
cr24Team01:40
this isn't how psuedo works... is there another optional mixin flag I'm missing?
KyrptonaughtTeam01:57
Yeah psuedo goes on the class itself for if the class may not exist
cr24Team01:57
Okay I got it, never done this with mixins before so let me know if anything's wrong or feel free to make a change to it yourself
made a separate optional mixins.json which throws a fit when loaded with sinytra but it does load and the PL portal works 100%
no issues on normal fabric
Okie dokie all good on my end, at your leisure https://github.com/kyrptonaught/customportalapi/pull/107
GitHub
1.20.0/1 Sinytra end portal mixin patch by MBatt1 · Pull Request #1...
As discussed in the PL discord thread. Functional with latest version of Paradise Lost on Sinytra
KyrptonaughtTeam02:03
Oh that works too, I think you could’ve just thrown require=0 in the redirect
cr24Team02:09
it seemed like require was for something different but yeah that does it too my bad
I've corrected it to be simpler. let me know when the version is available and also if you want PRs for the other 1.20.x versions FYI, the portal exit sounds doesn't work on Sinytra for some reason, entry sound is correct though
KyrptonaughtTeam03:48
Bumped the version to beta65, pushed it
Feel free to submit PRs to the other branches as needed
I’ll look at them tomorrow then
cr24Team13:41
awesome, thank you so much
@seb "vey" f. when you have a chance, please try loading the b2.2.2 version of PL I just released and it should now be working on Sinytra
seb "vey" f.15:14
Replying tocr24@seb "vey" f. when you have a chance, please try loading the b2.2.2 version of PL I just…
heyyy! it works!!!
weird tho, the sound for exiting the portal is just the normal nether one
cr24Team15:16
yeah I think that is just sinytra weirdness, it works on normal fabric but I think thatll just be an artifact of using sinytra which is in beta
But glad to see it works at least 95%!
KyrptonaughtTeam16:07
If you feel like trying to debug it, here's where we attempt to play the custom sound https://github.com/kyrptonaught/customportalapi/blob/c844099ed54c4cc518dc5bcf6a90ab99c85845d6/src/main/java/net/kyrptonaught/customportalapi/mixin/client/WorldRendererMixin.java#L26
KyrptonaughtTeam16:16
When a player is teleported through a portal a WorldEventS2CPacket is sent. The eventID is 1032 and by default has no extra data. We hijack the sending of this packet and throw some custom data in there to specify which portal. We do the hijacking here https://github.com/kyrptonaught/customportalapi/blob/c844099ed54c4cc518dc5bcf6a90ab99c85845d6/src/main/java/net/kyrptonaught/customportalapi/mixin/ServerPlayerMixin.java#L46(edited)
A couple things could be going wrong to cause this.

Related threads