BindCommands on 1.21.10 Not Working with FrostByte's Improved Inventory (Fixed)

I've read through the FAQ and all the help questions regarding BindCommands and none relate or help my issue. I installed the mod fabric-bind-cmd-2.0.0-beta.2.jar and I'm using Fabric loader 0.18.4, fabric-api-0.138.4+1.21.10, and fabric-language-kotlin-1.13.9+kotlin.2.3.10 I'll load into the game just fine and open the menu for BindCommands and try to add a command (e.g. /open or /seed) to any button at all and nothing happens. I've tried several commands and buttons and nothing works.

Hi

These are the other mods I'm using

@fella_guy Does the U keybind work on singleplayer? There is a chance you don't have permission to run /seed command on a server

I own the server and I have OP on it. If I type the command normally, it works

Hm

Try this version and send me the log file then. I added as much logs as possible to help me pinpoint the issue

Will do, i'll send it in like 5mins. Want me to do anything specific in-game?

You could try both singleplayer and multiplayer so that I can compare

log for multiplayer. will be using the same log file for SP

Are you playing on Minecraft Realms?

No. It's a fabric java server I'm running on a self owned linux machine

This is so weird, bindings are loaded correctly

Let me know if you want me to screenshare and go more in-depth if it'll help

Could you zip your mods? I'll try it myself first

Sure

It feels like one of them is doing something to either Minecraft's binding system or network handlers, because they are the two only things that are required for this to work

What caused it?

Not sure

Alright. I'm here if you need me to send or do anything else to help

The crash occurs only in debug mode... annoying But yeah, when I loaded those mods normally the keybinds don't work

Hmm, that's quite weird. I'm not sure what the difference is between debug and normal. You running debug through eclipse/jetbrains?

Yes, JetBrains. Can you try disabling Frostbyte's Improved Inventory?

I'll try it now

I'll try to fix the incompatibility

Alright, thanks. So it's a compatibility issue on your end or frostbyte's end?

No idea. I guess theirs

Well I can try to communicate it to them if it's not on you

https://github.com/FrostbyteGames1/Frostbytes-Improved-Inventory/blob/master/src/main/java/net/frostbyte/inventory/mixin/KeyBindingMixin.java Hmm

Oh, they don't forward it?

Seems like it

So you want to put in a issue on the git or you want me to do it? You might have more detail to put in. So in your mod you forward/next the input?

If they have a Discord server you can mention you can notify them there. I'll try to investigate why that mixin is doing that. After a quick look it seems like it ignores all non-minecraft bindings (?)

I don't see a discord for them or any other contact

I'll try to fix it first. I want to remove dependency on Fabric API anyways, so it might be a good start

Alright, np, I await any news.

Can you test it before I publish?

Sorry, didn't see the message, was in a dnd sess, will test now

I rewrote the way key events are detected. Previously it was checking every tick if a bound key was pressed. Now I'm hooking into Minecraft key press event, retrieving a keybind based on that, and executing all commands, if it exists.

Ah nice, that's much cleaner