paradise-lost Sunday 25 December 2022

55 messages5 people

chorb00:19
Do you guys, by any chance, remember when you coded that thing where leaves change on Christmas?
It has officially broken almost every leaf block texture in both of our modpacks which use your mod(edited)
and we're getting 20+ complaints daily because of it
https://github.com/devs-immortal/Paradise-Lost/commit/6e5a3a3e492a59bfd929da7eaa032a7587fc08ac
GitHub
Christmas leaves, how fun! · devs-immortal/Paradise-Lost@6e5a3a3
how fun indeed
I would maybe be careful in the future when adding something to your dimension mod which has nothing to do with the dimension
because this mod has caused two major problems in the last month
cr24Team00:56
it affects all leaves?
chorb01:00
Replying tocr24it affects all leaves?
most
especially modded ones
cr24Team01:16
nice idk how we didn't ever see this
issues with PL chests are epic too
AllyJax01:58
so I can't find an answer for this anywhere but will this mod be updated for 1.19.3?
cr24Team02:00
it will be, we're working through a lot of registry changes that were changed in 1.19.3
AllyJax02:01
ah alright, just was making sure as I hadn't heard or seen anything about it being updated anywhere. Heard that the registry changes were a nightmare as well lol
cr24Team02:03
it is lol
AllyJax02:04
fun, still quite annoying they decided to do this in a .x update
chorb04:29
I can not stress this enough
please do not implement more random features into paradise lost
which have nothing to do with the actual point of the mod
https://chorb.is-from.space/DiscordPTB_un3mgiugAt.png
chorb
chorb
chorb
chorb
we are getting so many complaints about the missing leaves textures that, while people were discussing it, another person came in asking for solutions
a month ago it was the rich soil and farmer village issue which went unfixed for weeks
that wasn't nearly as bad as 90% of modded leaves having missing textures
cr24Team04:32
yeah, I'm not sure why we have this feature at all I thought it was unimplemented but I believe it's from a time before I was heavily involved in the code side of PL, it really shouldn't be in, and I'm not certain it ever worked, it was implemented randomly by a dev we don't really have anymore
chorb04:32
I see
cr24Team04:33
I have no idea how it never was a problem before though, it's probably been 2 christmases since it was added
chorb04:33
it supposedly has something to do with sodium
a sodium update in the last year has something to do with it
cr24Team04:35
well I know a "sorry" doesn't cut it, unfortunately I think this will just have to pass and it won't be a problem next year. I'll make sure nothing happens on Halloween, nothing should, but just in case.
chorb04:37
The code is checking the user's computer calendar
it should be relatively easy to test
cr24Team04:37
yeah
chorb04:37
I'll ask a few people to set their calendar to October and see what happens
cr24Team04:38
thank you, if someone does find an easy fix msg me and I can make an announcement if appropriate
chorb04:39
the easiest fix to the christmas issue is to just set calendar time to any point before or after the defined dates in the code
cr24Team04:39
Trying to do some damage control while other staff is occupied with the holidays
chorb04:39
there seems to be a lot of unnecessary code bloating the jar ^_^
the fully textured incubus core items which only devs can use
the halloween and christmas stuff which is slightly unimplemented and also breaks modded leaves
theres probably other things too
might be worth looking over the code at some point as a team & removing some unnecessary things to prevent future issues
cr24Team04:41
I just made a PR to incubus core about unused textures and code, and trust me about how radically different the indev version of PL is, but a lot needs to be done
chorb04:42
I appreciate it
Jack PapelTeam04:50
We've been talking about de-bloating incubus core for a while. We're looking to get started on that soon
Deleted User07:24
Replying toAllyJaxso I can't find an answer for this anywhere but will this mod be updated for 1.19.3?
registry changes are cancerous to deal with.
Deleted User07:24
Replying tochorbplease do not implement more random features into paradise lost
I personally LOVE the christmas decorations
but it breaks leaves
if the leaves bug is fixed then im happy
but it should be its own mod tbh
Deleted User07:29
Replying toJack PapelWe've been talking about de-bloating incubus core for a while. We're looking to get…
incubus core breaks a lot of stuff
Jack PapelTeam07:49
It sure does. A lot of test stuff should be moved into a separate package and things should be modularized
Deleted User07:51
^^ 100% agree
unfortunately tho there isn't enough manpower to fix and maintain all the projects
atleast from what I know