mod-dev-talk Tuesday 3 August 2021

123 messages6 people

Jack PapelTeam00:00
Typo on your latest pull request Solly, it should be "wearables", not "wearbles"
SollyTeam04:49
Replying toJack PapelTypo on your latest pull request Solly, it should be "wearables", not "wearbles"
Fixed
I'm going to get this working before moving on to fixing mixins, access wideners, etc. to avoid diverging too much at once
SollyTeam05:19
@Azzyypaaras Thoughts on this?
Lets me write like this
Which is nice, but it's very nonconventional
AzzyypaarasTeam05:54
@Solly that is... wack, yet surprisingly sleek
Perhaps see if anyone else ~~cough cough haven~~ has anything to say
SollyTeam05:55
@Haven King
If I'm not mistaken, it should be replaced with static calls as usual in the bytecode.. although I usually don't call static methods on instances, so idk
Haven King05:56
What is block
And what is B
SollyTeam05:57
block is a method that creates an item Settings for the aether blocks category
B is defined in the first screenshot
Haven King05:57
If they're all the same, why not just have a single static instance?
SollyTeam05:57
I probably will before I'm done(edited)
Haven King05:57
AetherBlocks should not be able to be instantiated.
SollyTeam05:58
The block registry was constantly changing it, so I replaced it with it with a method call there, and it carried over to the items(edited)
Haven King05:58
Especially as those are static fields, you should just reference them with AetherBlocks.HOLYSTONE_WALL etc.
SollyTeam05:58
Yeah, the reason for the instantiation was to shorten the lines to improve readability. Yes, it's messy
Haven King05:59
You can just do a static import then.
SollyTeam05:59
No, because the block names are the same as the items
Haven King05:59
Though that's not really best practice either, as then the items and fields have to have different names.
Right.
Do we ever reference block items in code? Is there a reason they each need their own field?
SollyTeam06:00
Yes
Haven King06:00
I don't see the issue with doing AetherBlocks.WHATEVER.asItem()
SollyTeam06:01
Well, not often right now, because it was always asItem, but we will
Haven King06:01
It's only marginally longer than AetherItems.WHATEVER and reduces codebase complexity significantly.
A
AzzyypaarasTeam06:01
Replying toHaven KingI don't see the issue with doing AetherBlocks.WHATEVER.asItem()
There is a massive issue don't you see, it takes half a second longer to type
- 🙃1
SollyTeam06:01
reduces codebase complexity significantly
How?
AzzyypaarasTeam06:02

Haven King06:03

Because then you can have just one method in AetherBlocks that's called for each block that needs an item.

static <T extends Block> T register(Identifier id, T block) {
  T registered = Registry.register(Registry.BLOCK, id, block);
  Registry.register(Registry.ITEM, id, new BlockItem(registered, ITEM_SETTINGS);

  return registered
}

(edited)

SollyTeam06:04
https://canary.discord.com/channels/770691727568404521/770723749565300798/871577667407867924
AzzyypaarasTeam06:05
Do not question why blueberries are BlockItems
You do not want the answer.
Haven King06:06
I don't think any of those are major benefits. For the few block items that do look out of place in the midst of other blocks (such as blueberries), those few could simply be registered in the items class.
SollyTeam06:08
It looks like it does still get B, then immediately yeet it
y though
SollyTeam06:10
Replying toHaven KingI don't think any of those are major benefits. For the few block items that do look out…
Well it's easy for me to do that instead, if azzy wants me to
AzzyypaarasTeam06:15
Go for what haven is suggesting
At any rate our item ordering is fucked :3
We should perhaps look into some way of fixing that...
Haven King06:24
Item ordering doesn't really matter (functionally). You can just rearrange the entries 🙃
SollyTeam06:31
Replying toAzzyypaarasAt any rate our item ordering is fucked :3
Wdym it's fucked?
AzzyypaarasTeam06:34
Replying toSollyWdym it's fucked?
Order ain't great and things aren't really well grouped
AzzyypaarasTeam06:34
Replying toHaven KingItem ordering doesn't really matter (functionally). You can just rearrange the entries 🙃
I know there was a way but I forgot how, iirc it was a bit annoying
SollyTeam06:34
I fixed the item ordering
Haven't regrouped them though, other than moving a few between groups
SollyTeam07:22
So I just wrote a system to register the blockitems in the blocks class, along with a way to sort them before they get registered, solving that as well
Then I realised that it's harder to read than just putting the items in the items class(edited)
Hmm
Nvm I fixed it, it's nice again
SollyTeam07:49
@Azzyypaaras Any particular reason why traps didn't have blockitems?
And swet drops(edited)
AzzyypaarasTeam07:50
good question
idk
SollyTeam07:51
I'll just add them then
They don't have an inventory model but idc
SollyTeam11:33
Commit messages go brrr
Jack PapelTeam11:35
Lmao
SollyTeam11:36
Why
Tf
Is the build failing
I don't get it
There's nothing wrong there on my end; it just seems to be a random error in a part of the code I never touched
The same fucking line in the existing code
@Kyrptonaught any idea?
SollyTeam13:27
I'm almost done with the current pile of changes, so any testing or code feedback is appreciated
Jack PapelTeam14:28
I have a rare moment to myself, so I can check things out
One thing I noticed on github though is that instead of register it says "add". I know it's because you're adding it to a registry queue but I think "register" is more intuitive. In my opinion at least
Jack PapelTeam14:52
Can't create an aether portal
Stone traps don't have textures anymore (if they had before)
Just the items
cr24Team14:58
the traps shouldn't have item forms
well i guess they should
but shouldn't be obtainable in survival
Jack PapelTeam15:45
After looking the code a bit more, I'm actually happy with add being the method name. It's quite succinct
Jack PapelTeam15:52
Why is this a method rather than a variable?(edited)
grassBlock()
Tbh it's pretty nice that it's a different color tho
@Solly
KyrptonaughtTeam16:29
Replying toSolly@Kyrptonaught any idea?
What error are you getting?
SollyTeam21:14
Replying toJack PapelWhy is this a method rather than a variable?
Because it gets modified, and the two would interfere with each other if it were a variable
SollyTeam21:41
Replying toKyrptonaughtWhat error are you getting?
https://github.com/devs-immortal/The-Aether/pull/446/checks?check_run_id=3230307284
Only on ci. It's fine for me
SollyTeam22:42
Replying toJack PapelStone traps don't have textures anymore (if they had before)
They never did
SollyTeam22:43
Replying toJack PapelCan't create an aether portal
Hm? The aether portal item is broken, I know that. You mean you can't create one normally either?(edited)
Jack PapelTeam22:44
Oh, I only tried via the item
SollyTeam22:45
The item is broken in the main branch as well last I checked
AzzyypaarasTeam22:45
Oh, I noticed that
Portal size seems to have randomly been raised back to nether portal size
Anything smaller than that does not work
SollyTeam22:46
It was like that when I first got here(edited)
The item still worked though
Is anyone opposed to me just removing the aether portal item and giving aether portal blocks an item?(edited)
There's no reason for them to have a frame in creative testing, and that would be a lot simpler - just give the portal a blockitem(edited)
SollyTeam22:57
(@Azzyypaaras)
AzzyypaarasTeam23:05
I
I am pretty sure that would not even work
Portal blocks work like nether portal oens
You can't just build one off of individual blocks
@Solly
SollyTeam23:06
You can; they just break when updated
One block can exist on its own without anything special
Jack PapelTeam23:07
Yeah I believe before they removed the nether portal item it was that way
AzzyypaarasTeam23:07
I would rather we not have that
It feels too janky
The creative inventory is not a debug tool, it is still a central mechanic of an entire gamemode
We cannot just throw any trash we want into it
Jack PapelTeam23:08
Not every block item needs to be in the creative inventory
Just like how command blocks aren't in there
AzzyypaarasTeam23:09
If you need a command to get the portal item then at that point you can just use setblock
SollyTeam23:09
What about adding the item, but only adding it to a group when in a dev environment?(edited)
Jack PapelTeam23:09
Yes but in a dev env it can be set to be given to the player by default
AzzyypaarasTeam23:09
That is a good idea
SollyTeam23:10
Then I can add it to the food category as well
AzzyypaarasTeam23:10
though the best way to go would perhaps be, you know, fixing the portal item
Jack PapelTeam23:12
I suppose we're sort of fixing a non-problem
Since it's a dev tool anyway
The current portal item should be taken out of the creative inventory when not in a dev env imo too tho
Since you're technically not supposed to be able to make a portal that small in normal play