mod-dev-talk Saturday 31 July 2021

54 messages4 people

Deleted User10:38
I'm trying to use the portal API
By @Kyrptonaught and it's looking good. How do I set the block to something that isn't the custom portal block?
Jack PapelTeam10:39
Are you trying to set the frame block?
Deleted User10:39
The portal itself, not the frame
Jack PapelTeam10:39
Ah
Deleted User10:39
Trying to make it server-side only
KyrptonaughtTeam10:39
How would a custom block work serverside though?
Jack PapelTeam10:40
I think they don't want it to be a custom block
Deleted User10:40
Well I could use polymer for custom blocks, but I basically want the block to be the vanilla nether portal block
So players don't need a client mod(edited)
If code changes are needed I'd be very happy to open a PR for them
KyrptonaughtTeam10:43
This is kinda half baked into the lib already
The issue is the portal itself handles the logic for the player being inside the portal
So you do need a custom block, or mixins to nether portal
Deleted User10:43
Hmm
I could do a custom server-side block and trick the client into thinking it's a vanilla portal
KyrptonaughtTeam10:45
I think I have this implemented and working in a local branch. Might’ve been for 1.16 though
Can that be done without something like polymc?
Deleted User10:45
Polymer
KyrptonaughtTeam10:45
Which I do have a working version of btw
Haven’t heard of that?
Deleted User10:45
Replying toDeleted UserPolymer
I think polymc uses it now
It's a server-side block library
https://github.com/Patbox/polymer
GitHub
GitHub - Patbox/polymer: Library for creating better server side co...
Library for creating better server side content! (For Fabric) - GitHub - Patbox/polymer: Library for creating better server side content! (For Fabric)
Well polymc doesn't use it
But it's there
KyrptonaughtTeam10:47
Interesting, that could work then
Deleted User10:48
Will try then
And for setting the block itself
KyrptonaughtTeam10:48
The aether does it here, line 32 https://github.com/devs-immortal/The-Aether/blob/1.17/src/main/java/com/aether/world/dimension/AetherDimension.java
GitHub
The-Aether/AetherDimension.java at 1.17 · devs-immortal/The-Aether
The Aether mod port for Fabric 1.16.4. Contribute to devs-immortal/The-Aether development by creating an account on GitHub.
The block must extend CustomPortalBlock though
Deleted User10:49
Ok, thank you
It's a really cool library
Seems to be an issue here - kotlin doesn't want me to extend it
Time to use java
KyrptonaughtTeam10:58
Thank you! It’s still very much a work in progress, but its starting to come together.
Java good
Deleted User11:02
I have a feature request for it
Would you be able to make the custom portals (tinted ones) show nether portals on vanilla clients, but tinted portals on modded clients?
I can add that with a mixin, I think
CustomPortalBlock#61 returns air normally, should probably return nether portal block
K
KyrptonaughtTeam11:20
Replying toDeleted UserWould you be able to make the custom portals (tinted ones) show nether portals on…
Yes I am planning on doing this very soon. I’ve got it almost working on a 1.16 branch, so I’ll port that over to 1.17.
- 👀1
KyrptonaughtTeam11:20
Replying toDeleted UserCustomPortalBlock#61 returns air normally, should probably return nether portal block
This should return air, as it’s resetting the block back to air if the portal is no longer valid, ie a frame was broken
Deleted User11:21
Ah makes sense
Deleted User11:21
Replying toKyrptonaughtYes I am planning on doing this very soon. I’ve got it almost working on a 1.16 branch…
Sounds great, please give me a ping when it's ready. In fact I'd be happy to help port
Deleted User12:39
Also @Kyrptonaught it appears the portal tint option is broken on 1.17 (testing with client mod here)
cr24Team22:33
how did this happen
what is this code
bruh fr who wrote this this is incredibly inefficient if I understand it right
KyrptonaughtTeam22:49
Replying toDeleted UserAlso @Kyrptonaught it appears the portal tint option is broken on 1.17 (testing with…
Are you using a custom portal block?
Jack PapelTeam23:36
Things have really picked up around here during my stay
I probably won't be able to work on this project for the next week, at least
The aether signs pull request is ready to go if it doesn't crash. I can't test it so if someone else can, it'd be great