mod-dev-talk Saturday 26 June 2021

127 messages9 people

sword_cat15:01
Could i fix the aerwhales code so they dont fall down y 20
kalucky0Team15:02
Yes
sword_cat15:08
@kalucky0 Ok i did so. I just need aproval for my pr(edited)
CDAGamingTeam15:16
You need to seperate your branches @sword_cat
sword_cat15:16
how
CDAGamingTeam15:16
By making a new branch based on the 1.17 base branch
sword_cat15:16
i have no idea how to do that
CDAGamingTeam15:17
https://www.google.com/search?q=git+create+branch
sword_cat15:20
other question: when will someone check my texture pull request? never? github says that there is less and less contribution to the commit, less and less people are active...
CDAGamingTeam15:23
CC @cr24 needs to look over it to approve it, among other members as well
Textures are not an insta-merge type deal.
cr24Team15:29
im waiting for azzy because they sleep in so damn late in the day
cr24Team16:32
whoever keeps trying to increase the decay range of aether leaves: please stop it has never worked, and we don't need to anyways
this is the third time i've had to remove it
Crackers010616:33
@CDAGaming Would like an option for legacy Golden Oak tree gen
it's already setup to generate like that in my fork, so you can copy from that
CDAGamingTeam16:35
As said, send me whatever you wish
@cr24 why take away the fortune enchant compat
and the ability to use silk touch on them?
cr24Team16:37
I made the equivalent to vanilla leaves
CDAGamingTeam16:38
My initial copy was already that xD
The original loot table fixes were all carbon copies of oak leaves xD
cr24Team16:38
well mine is directly copied besides the crystal tree predicate
copied from acacia if it matters(edited)
silk touch still works
CDAGamingTeam16:39
Alrighty, I trust your judgement here, deploying it to the server in a few minutes xD
Crackers010616:39
Replying toCDAGamingAs said, send me whatever you wish
https://github.com/Crackers0106/The-Aether/blob/master/src/main/java/com/aether/world/feature/AetherConfiguredFeatures.java#L88
GitHub
Crackers0106/The-Aether
The Aether mod port for Fabric 1.16.4. Contribute to Crackers0106/The-Aether development by creating an account on GitHub.
cr24Team16:40
just fixed leaf piles to be like grass as well
CDAGamingTeam16:40
O.o NICE
I'll actually hold off on rebooting, mainly to get all these fixes in in one go rather then multiple reboots
Also man did i miss the multi-cloud layers
Archanum17:21
Is the decay range of Aether leaves how long it takes them to dissappear?(edited)

CDAGamingTeam17:22

    @Override
    public void randomTick(BlockState state, ServerWorld world, BlockPos pos, Random random) {
        if ((state.isOf(AetherBlocks.GOLDEN_OAK_LEAVES) || state.isOf(AetherBlocks.FROST_WISTERIA_LEAVES) || state.isOf(AetherBlocks.BOREAL_WISTERIA_LEAVES) || state.isOf(AetherBlocks.ROSE_WISTERIA_LEAVES) || state.isOf(AetherBlocks.LAVENDER_WISTERIA_LEAVES))) {
            if(!(Boolean) state.get(PERSISTENT) && state.get(DISTANCE) >= 13) {
                dropStacks(state, world, pos);
                world.removeBlock(pos, false);
            }
        }
        else
            super.randomTick(state, world, pos, random);
    }

Yup.

This chunk was removed, so decay is now fully using just the vanilla method

cr24Team17:24
decay range is how far leaves can be from a trunk before they decay
manhattan distance
cr24Team18:19
Minecraft__1.17_-_Singleplayer_2021-06-26_13-18-29.mp4Video, 5.4 MB. Not stored in the archive.
🥴
@CDAGaming peep this
It's based on a loot table so it's easy to tweak
CDAGamingTeam18:21
Nice xD
cr24Team18:22
also theres a new class for any new loot tables we might want to add for other stuff
Crackers010618:22
yes I remember suggesting it dropping amber if you strip it
cr24Team18:23
also technically is a way to get gold but it would take forever
Crackers010618:23
guess not?
cr24Team18:24
there was some talk about it a long time ago
finally got around to it so that it's obtainable on the server
Jack PapelTeam21:12
Should swet be compostable?
Crackers010621:12
why?
it's not a plant or food
Jack PapelTeam21:13
it can be made into a food, like wheat can(edited)
arguably organic
cr24Team21:14
i don't think it should, since slime can't
its a slime variant
Jack PapelTeam21:14
Alright
Jack PapelTeam21:21
I think it's the same amount, but when eating a white apple it looks like you're just spewing particles
It looks like a lot more than other foods
I think it just looks that way though(edited)
Speaking of, should the white apple be compostable?
cr24Team21:24
yes
Jack PapelTeam21:24
Alright
cr24Team21:24
probably however much the regular apple can be
i'll check the particles for the apple it should be the same
Jack PapelTeam21:24
How about the candy cane and gingerbread man?
Jack PapelTeam21:25
Replying toJack PapelI think it's the same amount, but when eating a white apple it looks like you're just…
Took a look in F5, I think the particles just come out faster since the apple is eaten faster
And since I was in creative mode and could eat continuously, it amplified the spewing effect
C
cr24Team22:19
- 👀1
back in business baby
I'm going to touch these up with some new blocks as well
CDAGamingTeam22:22
HOLY SHIT WHAT
Wow I didn't think it would be feasable
Congrats
cr24Team22:26
why not? It really wasn't that bad
CDAGamingTeam22:28
Eh, mostly just bc I lacked the experience with structures
I thought there'd be more issues
cr24Team22:29
we weren't using it before but I don't think we had it then: FabricStructureBuilder
took me a while to find it
CDAGamingTeam22:32
Yea, about that
I kinda wanna steer us away from FAPI usages that can be done with Mojang's usages
CDAGamingTeam22:32
Replying tocr24we weren't using it before but I don't think we had it then: FabricStructureBuilder
Try and find a way to use Mojang's structure registration for this.
cr24Team22:33
I was, and it seems to be really screwy with placement data but I'll keep looking
CDAGamingTeam22:34
That's bc the spacing needs to be specified in the config manually
cr24Team22:34
problem is that as far as I can tell you can't provide a namespace but I might see a workaround
CDAGamingTeam22:34
The builder specifies an argument for the spacing, but it must be manually supplied with the mojang style
cr24Team22:48
done
no FAPI
CDAGamingTeam22:50
POG
I wonder if after this commit, we could modify the towers to have chests to give them some loot tables
cr24Team22:51
I'm about to do that
what kind of loot would be reasonable?
CDAGamingTeam22:53
Not sure tbh
@Haven King Think we can get an update to seedy behavior to use the world seed with salting configured structures?
Haven King23:17
Salts are so that different structures using the same spacing and separation don't just spawn on top of each other. Structure spawning already uses the world seed.
ColdFlame5323:19
Bruh is that like a naturally generating Aether watchtower ?! 😮 man that will spice exploring up majorly ! Is there a chest at the top ?
cr24Team23:19
there will be
taking suggestions now for what loot it should be
C
CDAGamingTeam23:21
Now that we can work on structures again, testing can become more spicy
23:21
and it incentives people to explore further out
- 👍1
cr24Team23:24
what're we doing for loot tho
CDAGamingTeam23:25
¯\_(ツ)_/¯
cr24Team23:25
rn I'm thinking: * Skyroot saplings * Sticks * Zanite gems/shards * Ambrosium * Cold Parachute * Skyroot Buckets * String(edited)
as options not as always
CDAGamingTeam23:25
String for certain
We need a valid way to get string
cr24Team23:26
golden oak saplings?
CDAGamingTeam23:26
We could try to mimic the mineshaft/stronghold loot table with aether items is my idea
Nah, saplings may be a bit much since realistically those decay xD
cr24Team23:26
Ok
so how about: * Sticks * Ambrosium * Cold Parachute * Skyroot Buckets * String
CDAGamingTeam23:27
Saddles may also be a good addition
We need a way to get those too
cr24Team23:27
ah yeah lets do saddles too
* Sticks * Ambrosium * Cold Parachute * Skyroot Buckets * String * Saddles
good?
CDAGamingTeam23:28
Also for the wells, we could also do a buried chest type deal with them as well
So some wells have a chance to spawn with a buried chest near it
cr24Team23:28
honestly I think the wells should just be wells
but we can
CDAGamingTeam23:28
It might work well, and be a good equivalent to buried treasure
But yeah that loot table looks good for now
While your working on data as well, do you think we could add in the recipies for the obsidian armor (Mainly as afaik they only need obsidian to craft, right)
cr24Team23:31
it's phoenix armor with icestone
not just obby
CDAGamingTeam23:31
Ah, I see
cr24Team23:31
it's way too OP for just obby
CDAGamingTeam23:31
That's fair
Carry on xD