mod-dev-talk Friday 25 June 2021

77 messages7 people

  1. Archanum

    It's impossible very hard to land on a moa without dying. Even jumping up a tiny bit and landing gracefully makes me lose like 7 hearts(edited)

  2. ColdFlame53

    Do you mean while riding a moa ? Or while jumping off a clip onto its back ?

  3. Archanum

    While riding a moa XD but now I would like to test the latter

  4. ColdFlame53

    Gotta be thorough (; hahaha

  5. Jack PapelTeam

    Think I got something going for two-tall floatingBlockEntities

  6. CDAGamingTeam

    O.o

  7. Jack PapelTeam

    I coded through like 3 different failed ideas before I landed on this current one(edited)

  8. CDAGamingTeam

    The simplest ideas always seem to work xD

  9. Jack PapelTeam

    Right now my code refers to a group of joined floating blocks as a "combo". Any ideas for a better name? combo may be a bit confusing

  10. CDAGamingTeam

    CombinedSet maybe?

  11. Jack PapelTeam

    Sure

  12. Archanum

    Call it a Cumulo as in a CumuloNimbus :thonk:

  13. Jack PapelTeam

    Oh, FloatingBlockSet

  14. Archanum

    I thought you were talking about floating block clouds

  15. CDAGamingTeam

    Eh CombinedSet would be more generalized

  16. Jack PapelTeam

    good point

  17. CDAGamingTeam

    Alrighty

  18. Jack PapelTeam

    Oh my god it is beautiful(edited)

  19. CDAGamingTeam

    Send video xD

  21. CDAGamingTeam

    mega pog

  22. Jack PapelTeam

    Doing some refactoring, then I'll make a pr

  23. CDAGamingTeam

    Alrighty

  24. Jack PapelTeam

    Alright I had to attend to my family, but making the PR now

  25. Jack PapelTeam

    What do you think about the name change to FloatingBlockStructure?

  26. CDAGamingTeam

    Seems alright

  27. Jack PapelTeam

    About the concurrent modification swet problem - I tested it out today and reproduced the issue

  28. Jack PapelTeam

    I thought to test it because I had a similar issue crop up in ClientWorldMixin and ServerWorldMixin

  29. sword_cat

    New texture for golden_oak_leaves.png. Could i upload it to the github page?
    Image shared by sword_cat

  30. CDAGamingTeam

    Sure

  31. Crackers0106

    this advancement does nothing because I just guessed on everything when making it lol
    Image shared by Crackers0106

  32. sword_cat

    Replying toCDAGamingSure

    how

  33. cr24Team

    make a pull request on github(edited)

  34. sword_cat

    isnt that a pull request?

  35. Jack PapelTeam

    Yeah they misspoke

  36. sword_cat

    k

  37. CDAGamingTeam

    @sword_cat Change the base to 1.17

  38. sword_cat

    Uh... i think i did something wrong...

  39. CDAGamingTeam

    ketufaispikinut wants to merge 177 commits into master from 1.17 Can't merge it like this lol

  40. sword_cat

    yes

  41. CDAGamingTeam

    Yea you chose master instead of 1.17 to merge into

  42. sword_cat

    dang. i have no idea how to just replace an image

  43. CDAGamingTeam

    One sec, ill get the texture location

  44. sword_cat

    k

  45. CDAGamingTeam

    Image shared by CDAGaming

  46. sword_cat

    files upload are disabled; file uploads requiere pusha ccess to this repository

  47. CDAGamingTeam

    You need to fork the repo

  48. sword_cat

    k

  49. Jack PapelTeam

    Top right of the github page there's a fork button

  50. CDAGamingTeam

    Image shared by CDAGaming

  51. sword_cat

    i forked it and uploaded my file using the upload button. it is now at the right place

  52. CDAGamingTeam

    Make a PR from your forked branch to the 1.17 branch on our end

  53. sword_cat

    pr?

  54. Jack PapelTeam

    Pull request

  55. sword_cat

    k

  56. Jack PapelTeam

    Up near the top it should say [devs-immortal][master] in two round boxes

  57. sword_cat

    k

  58. Jack PapelTeam

    You can write a description and submit

  59. sword_cat

    ok i did it ! yay!

  60. Jack PapelTeam

    Dope

  61. CDAGamingTeam

    Yea, PRs good to go, it's awaiting approval now

  62. sword_cat

    k