paradise-lost Monday 20 June 2022

160 messages11 people

Duplex00:31
message.txtText file, 18 KB. Not stored in the archive.
@gudenau
your welcome :)
rename configured_structure_feature to structure
oop they redid structures
{ "biomes": "#the_aether:has_structure/orange_ruin", "terrain_adaptation": "bury", "max_distance_from_center": 116, "start_height": { "absolute": 0 }, "step": "surface_structures", "use_expansion_hack": false, "spawn_overrides": {}, "type": "the_aether:orange_ruin" }
{ "biomes": "#the_aether:has_structure/skyroot_tower", "terrain_adaptation": "bury", "max_distance_from_center": 116, "start_height": { "absolute": 0 }, "step": "surface_structures", "use_expansion_hack": false, "spawn_overrides": {}, "type": "the_aether:skyroot_tower" }
{ "biomes": "#the_aether:has_structure/well", "terrain_adaptation": "bury", "max_distance_from_center": 116, "start_height": { "absolute": 0 }, "step": "surface_structures", "use_expansion_hack": false, "spawn_overrides": {}, "type": "the_aether:well" }
Jack PapelTeam00:55
@cr24 👀
Duplex00:55
with these changes it loads in prod now
I'm at least 30% sure the structure stuff is wrong but it loads and might be right
the new numbers might need tweaking
SollyTeam00:57
Why are these even defined in json?
Jack PapelTeam00:57
I didn't think the structures were
The noise is though
SollyTeam00:57
I added the labyrinth in java, I can move these over to it as well if needed
Jack PapelTeam00:57
@Duplex if this works, can you make a PR?
Duplex00:58
sure
Jack PapelTeam00:58
To the snapshots branch
Duplex00:58
Replying toSollyWhy are these even defined in json?
idk
Duplex00:59
Replying toJack Papel@Duplex if this works, can you make a PR?
done
ok now please finish the 1.19 update I want it :P
I have done my part lol
cr24Team01:03
double checking it, then will accept PR, thanks for the help!
Deleted User02:39
fds
Duplex04:13
also is the aether just disabled in the snapshot branch
like the dimension?
Jack PapelTeam04:14
No it's probably broken
Duplex04:14
rip
mfw
let me try and fix
Jack PapelTeam04:15
There's an MC Jira bug related to it I believe
cr24Team04:15
it should be working on latest commit, may need to try a new world
Jack PapelTeam04:15
If you look at Aether.java it has a link to the bug in there
Oh nevermind then
Duplex04:17
oh I see you fixed a mixin
it does not appear to be working
i'm on 8771d597b4b25f27efb79debadb3bdfd3f5326fc
registerDimensionTypes and registerDefaultOptions are never called hmmm
cr24Team04:27
i believe those may be defined in json rather than in code
because
is it just crashing or whats in the console?
Duplex04:29
uhhh
there is no aether
and there is nothing in the console
of note
there just is no aether
the dimension does not exist
the blocks exist
everything else exists
the dimension does not exist
like at all
cr24Team04:31
portal not work?
Duplex04:31
/execute in ___ does not have the aether as a valid tab completion
nope
cr24Team04:31
even upon making a new world?
Duplex04:31
but it's not that the portal isn't working
yeah
it's the there is no aether dimension
cr24Team04:31
hmm
it worked fine for me on a new world
Duplex04:32
cr24Team04:32
odd
Duplex04:32
are you testing in dev env or prod
cr24Team04:33
dev
Duplex04:35
same
this is my console
message.txtText file, 56 KB. Not stored in the archive.
cr24Team04:35
any other dev wanna take a look?
Jack PapelTeam04:36
I thought we fixed this bug
Is snapshots up to date with 1.18.2
cr24Team04:37
it seems to not be a problem for me just duplex
no idea
Duplex04:38
this happens across runs fyi
Duplex04:38
Replying toJack PapelIs snapshots up to date with 1.18.2
yes
Jack PapelTeam04:39
I'll take a look
Duplex04:54
it seems preset screen mixin is borked
yeah I literally can't get it to work
both dev and prod do not work
Duplex05:11
Replying toJack PapelI'll take a look
does it work for you or is this just a me thing?
Jack PapelTeam05:12
Just tested, doesn't work for me either
Duplex05:12
@cr24 are you sure you don't have uncommitted changes or something
Jack PapelTeam05:13
If you exit and rejoin the world it works
Duplex05:13
whar
Jack PapelTeam05:13
It's related to that MC bug I mentioned
It gets it on the second try
Would be nice if we could fix that though
Duplex05:13
so is it not possible to get it on the first try?
Jack PapelTeam05:14
I mean, we could fix the bug I suppose
Duplex05:14
I wanna do dimension stacking lol
Jack PapelTeam05:14
Ah I don't like that it has a "Experimental world settings" popup whenever you load the world
Duplex05:14
also oop my changes fucked the aether lol
rip generation
Jack PapelTeam05:15
Oh yeah they did(edited)
Duplex05:15
this is fixable though
Jack PapelTeam05:16
Yeah
I guess @cr24 will have to dabble with json after all(edited)
Also @gudenau I forgot if you were already busy with something, but is there something we can do about this aether-not-generating-first-try thing and the experimental world settings popup?
gudenau05:20
I swear I fixed that.
Jack PapelTeam05:20
1.19 probably un-fixed it
and it's on the client this time, not the server
gudenau05:20
Jack PapelTeam05:20
Well maybe both, idk
gudenau05:21
I swear to god if they did what I think they did my changes would have been done faster.
Not that I can check right now, it's late.(edited)
Jack PapelTeam05:21
Alright
SollyTeam05:46
Replying toJack PapelAlso @gudenau I forgot if you were already busy with something, but is there something…
I can fix it sometime. After the checkstyle passes, I'd be happy to dive in and fix things
Jack PapelTeam05:48
I won't be fixing the checkstyle until after all the B1.7's PRs are merged
Oh but you can rebase stuff off 1.19 now
Just make a branch for it first
SollyTeam06:00
My stuff is based on the 1.7 branch(edited)
Jack PapelTeam06:00
Is that a question or is it just supposed to be a noun
Cause it's a noun rn
SollyTeam06:00
What?
Jack PapelTeam06:01
I don't know what you're saying
Gotcha
I assume you're good with git right?
SollyTeam06:01
Yeah
Jack PapelTeam06:03
You can make a 1.19 branch based off snapshots, and rebase b1.7 off of it(edited)
SollyTeam06:04
I don't want to handle the b1.7 porting, it's too much of a mess
Jack PapelTeam06:04
Alright
I'll do that when I'm free then
SollyTeam06:04
I've stopped working on the dungeon for now anyway
Jack PapelTeam06:05
Alright
Jack PapelTeam07:22
Oh actually, neither of you do that. I have to make snapshots up to date with master first. It already has some basic fixes that might just solve the problem
But of course, it's midnight now, so I'll do it later(edited)
I should be waking up in about ten hours, so if you ping me then, I'll remember
fanaco11:59
oh i just checked
@role
my world does just not have a aether world
i mean in the files
there's no folder
thats must be the reason it doesnt work
fanaco15:33
@role
sorry for pinging
u may sleep at this time
im in france :/ didnt realise
kalucky0Team15:34
Most of them are asleep
fanaco15:34
kk
u cant help me ?
kalucky0Team15:35
I'm not up-to-date with the project
Evelyn15:52
Europe is awake
KyrptonaughtTeam16:22
Replying tofanacomy world does just not have a aether world
You don’t have a world file for aether Bc it isn’t getting registered. Im not as caught up in the project, but didn’t the other guys say this was fixed in a new release
fanaco16:22
so what do i have to do
?
Hisami16:23
Replying toEvelynEurope is awake
it was awake 10 hours ago lmao
Evelyn16:24
Yeah but i wake up at 2pm at the moment so i’m going on my internal time 😂
Hisami16:29
ok
KyrptonaughtTeam16:30
Replying tofanacoso what do i have to do
Are you using a mod pack? What version of the aether is in the pack?
fanaco16:39
betterminecraft 1.18.2
KyrptonaughtTeam16:42
Can you check in mod menu what version of the aether you have?
fanaco16:43
v1.6.9
but it works on singleplayer
it just doesnt work in multiplayuer
cr24Team16:58
who is hosting the server? Is the same version on the server host/host's computer?
fanaco17:43
the server is on a website :/
and yes its the same version i think
ill check
im the host
Jack PapelTeam20:10
Oh yeah that's a bug with the latest version
There's a fix in dev builds but it's not released yet