mod-dev-talk Saturday 8 January 2022

98 messages3 people

SollyTeam02:28
Changing a 6 to a 7 be like
Jack PapelTeam02:29
I'd like to think that the method is just return 7;
SollyTeam02:33
Actually, I can do that
@Jack Papel
Jack PapelTeam02:35
> says he can't do modifyarg > immediately responds with code featuring modifyarg
SollyTeam02:35
Yeah I realised the issue doesn't exist anymore
Jack PapelTeam02:35
What was the issue?
SollyTeam02:36
Slice being awkward to match
AzzyypaarasTeam02:36
tf are you two nerds up to
Jack PapelTeam02:36
Alright, idk much about slice so I'll take your word for it
SollyTeam02:36
Needing to use another parameter to determine if it should be modified
SollyTeam02:37
Replying toAzzyypaarastf are you two nerds up to
Enjoying mixins
AzzyypaarasTeam02:37
SollyTeam02:38
Speaking of which
@Azzyypaaras the filled map mixin is annoying me to this day
Can I attempt to do it properly?
I'm not entirely sure what it's even doing, though
My decompiled code is different enough from the copypaste to be a pain to differentiate everything
Jack PapelTeam02:41
It's been bugging me too lol
Just waiting for some map mod to mess up because of it
AzzyypaarasTeam02:42
iirc, it makes any void blocks a sky color, because otherwise it looks kinda ugly
Jack PapelTeam02:42
Hm that sounds like it should be a one liner
SollyTeam02:43
Yeah, that should be easy
I'll do that now
AzzyypaarasTeam02:44
shoot
SollyTeam02:47
Does it ignore blocks at the bottom of the world rn?
AzzyypaarasTeam02:48
Replying toSollyDoes it ignore blocks at the bottom of the world rn?
I have not looked at the code in a good few months now
But I think no
It only does it if it finds void
SollyTeam02:49
aa <= world.getBottomY() + 1
I'll test it
It's fine, nice
SollyTeam03:03
@Azzyypaaras How's this, instead of the fixed blue background?
Clear background
Would be especially nice for people with clear item frame mods
Jack PapelTeam03:05
Hm I wonder why the background is checkered instead of empty
I think it'd look nicer empty or blue, but the checkered is kinda weird
SollyTeam03:06
Checkered is just how vanilla handles empty maps
Create one in vanilla and the parts that aren't filled in are the same
Jack PapelTeam03:06
Oh
I wonder why they did that
SollyTeam03:07
Idk
But given rare actual usage of maps, I think this gives aether maps a real purpose for map art
Up to @Azzyypaaras

SollyTeam03:17

Here's the code, anyway

@Mixin(FilledMapItem.class)
public abstract class FilledMapItemMixin {
    @Redirect(method = "updateColors",
            at = @At(value = "FIELD",
                    target = "Lnet/minecraft/block/Blocks;BEDROCK:Lnet/minecraft/block/Block;",
                    opcode = Opcodes.GETSTATIC))
    private Block getBottomBlock(World world, Entity entity, MapState state) {
        return world.getRegistryKey().equals(AetherDimension.AETHER_WORLD_KEY)
                ? Blocks.AIR : Blocks.BEDROCK;
    }
}

Replace Blocks.AIR with another block to change the colour

AzzyypaarasTeam03:20
Oh damn that's nice
SollyTeam03:21
I can't bothered PRing it, so just replace it yourself sometime
AzzyypaarasTeam03:34
Wait I just realized
This is wrong
You are feeding it a block here
The mixin feeds it a unique color
Jack PapelTeam03:35
Solution: unplaceable dev block with that map color(edited)
Or placeable, why not
Better yet, you shouldn't even need to register it
SollyTeam03:41
Replying toAzzyypaarasThe mixin feeds it a unique color
Yeah, replacing it with a colour is doable
The issue is that then you have to deal with colour ids
And since there can only ever be 64 colours, is it really worth wasting one on a background?
AzzyypaarasTeam03:42
Replying toSollyAnd since there can only ever be 64 colours, is it really worth wasting one on a…
Yes.
We are probably the only persons in the entirety of modded to ever add map colors
SollyTeam03:43
Easiest solution then, just add the aether colour and use it for aerogel or something
AzzyypaarasTeam03:43
hm
Not a bad idea
SollyTeam03:43
At least don't waste it only on a background(edited)
AzzyypaarasTeam03:43
You know I wonder what happens if you go above id 63
SollyTeam03:43
Not sure, but I don't think it'd be good(edited)
Jack PapelTeam03:44
What number type can't go above 63?
SollyTeam03:44
Iirc the map only uses 6 bits to store the colour id
Jack PapelTeam03:44
Oh
AzzyypaarasTeam03:44
Maps are fucking wack tbh
SollyTeam03:44
You could check the length of the map colour array, and if it's full, set the background colour to white, otherwise add a new colour
Want me to add that?
AzzyypaarasTeam03:45
Replying toSollyYou could check the length of the map colour array, and if it's full, set the background…
wah
SollyTeam03:45
Use a new colour, but fall back to white if all the map colour ids are taken
AzzyypaarasTeam03:45
Ahah, maps are saved directly to world
and
hm
what the fuck is putByteArray
Jack PapelTeam03:46
I would assume it puts a byte array
AzzyypaarasTeam03:47
Ok so uhhhhh
MapState gives me a MigraineState
But there is nothing that looks like it would stop us from expanding color ids
SollyTeam03:48
Just
Don't
AzzyypaarasTeam03:48
It would require a bit of mixin, but there aren't any particular hard caps
AzzyypaarasTeam03:48
Replying toSollyDon't
Solly solly
I literally bullshitted bloom into incubus core
Common sense cannot stop me
SollyTeam03:49
Well if you want me to do the fallback thing, I can
But I'm not expanding the map colours
At least not in the aether
In a library mod sure
AzzyypaarasTeam04:02
Replying toSollyIn a library mod sure
big Incubus Core hours
SollyTeam04:03
I feel like it'd be better off in a standalone mod to encourage other mods to use it