mod-dev-talk Friday 31 December 2021

129 messages5 people

Jack PapelTeam01:41
This mixin bugs me for some reason
It would be nice if there was an API that did farmland better, like with a map from farmland block to dirt block or something
cr24Team01:43
couldn't this be done by overriding the method in the farmland block extension
Jack PapelTeam01:43
Method's static(edited)
cr24Team01:43
o
bruh
Jack PapelTeam01:44
Needs to be added to FAPI imo
If they can have an API for fluid transfer through pipes then they can surely have one for farmland
It's called three times and only in methods that are non-static, so it could be done with overrides, but it wouldn't be that nice of code
AzzyypaarasTeam03:09
Replying toJack PapelIt would be nice if there was an API that did farmland better, like with a map from…
That sounds like it would fit nicely into incubus core
hmph, jack
Whenever you have the time and energy, mind doing a pass over AR and seeing what should be there and what should be moved to IC?(edited)
Jack PapelTeam03:10
Sure
Hm, it'd be nice if there was a way to find the location of the minecraft mods folder without having minecraft loaded
Doesn't seem possible though
cr24Team03:14
/.minecraft/mods(edited)
Jack PapelTeam03:16
Yeah I guess that's good enough
Jack PapelTeam03:53
The way we do DynamicColorBlocks is strange and seemingly unnecessary
e.g. AuralLeavesBlock & AuralHangerBlock
I think the DynamicColorBlock interface is not needed at all really
AzzyypaarasTeam03:59
Replying toJack PapelI think the DynamicColorBlock interface is not needed at all really
Shoot for changes if you want, our current impl is ripped off of BetterEnd
Jack PapelTeam03:59
Gotcha
AzzyypaarasTeam04:00
Not like inspired, I straight up copy pasted it and renamed a few methods for clarity
Jack PapelTeam04:00
Oh gotcha lmao
Maybe I'll take a look at what they did for what their inspiration was
Anyway, making those changes isn't gonna be very useful until this port is finished, so I'll hold off
AzzyypaarasTeam04:03
yeah
On the topic of the port, what is the current state of that again?
I forgor
Jack PapelTeam04:03
Waiting on christmas
That's passed, so I guess waiting on new years
🤷‍♀️
AzzyypaarasTeam04:03
I mean but like, before that, I already know the whole ~~useful~~ part of the team is on the other side of the world
Jack PapelTeam04:04
Not sure
Don't really remember
AzzyypaarasTeam04:04
My last memory was @gudenau unfucking stuff
Jack PapelTeam04:04
Did we end up not having to convert our java features? I believe so
AzzyypaarasTeam04:04
Ah, right
gudenau04:04
Yeah.
AzzyypaarasTeam04:04
We converted to json
gudenau04:04
Mojang changed things.(edited)
AzzyypaarasTeam04:04
Then gud came in
Took one look
Went "what the fuck did you guys do"
And started fixing things and moving them back to java
gudenau04:05
Json: Weird runtime errors Java: Weird compile time errors
Jack PapelTeam04:05
The current build runs
It seems like we need to mess with the dimension JSON, or maybe the biome JSONs (If those still exist in 1.18)
Cause the landmass is wholly bare
gudenau04:06
It generates now?
Jack PapelTeam04:06
Last I checked
gudenau04:06
Anyway, I am running two instances of mixin in Minecraft. AMA
:V
AzzyypaarasTeam04:06
Question: why
gudenau04:06
All will be clear later.
AzzyypaarasTeam04:07
Jack PapelTeam04:07
Speaking of java swing
I was making changes to InstallerGUI a few hours ago

org.spongepowered.asm.service.ServiceInitialisationException: LaunchWrapper is not available
    at sponge.mixin@0.10.7+mixin.0.8.4/org.spongepowered.asm.service.mojang.MixinServiceLaunchWrapperBootstrap.bootstrap(MixinServiceLaunchWrapperBootstrap.java:61)
    at sponge.mixin@0.10.7+mixin.0.8.4/org.spongepowered.asm.service.MixinService.runBootServices(MixinService.java:152)
    at sponge.mixin@0.10.7+mixin.0.8.4/org.spongepowered.asm.service.MixinService.<init>(MixinService.java:143)
    at sponge.mixin@0.10.7+mixin.0.8.4/org.spongepowered.asm.service.MixinService.getInstance(MixinService.java:169)
    at sponge.mixin@0.10.7+mixin.0.8.4/org.spongepowered.asm.service.MixinService.boot(MixinService.java:179)
    at sponge.mixin@0.10.7+mixin.0.8.4/org.spongepowered.asm.launch.MixinBootstrap.<clinit>(MixinBootstrap.java:87)
    at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized0(Native Method)
    at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized(Unsafe.java:1155)

Hmm.

I think I know how to fix this and it's so hacky and stupid.

AzzyypaarasTeam04:10
Replying toJack PapelI was making changes to InstallerGUI a few hours ago
Oh right that exists
Jack PapelTeam04:11
The default icons for java swing are so crusty
I expected them to be the standard windows icons but they're custom and 90's
Maybe earlier yet(edited)

gudenau04:11

From this:

this.bootstrapServiceLoader = ServiceLoader.<IMixinServiceBootstrap>load(IMixinServiceBootstrap.class, this.getClass().getClassLoader());

to this

if(getClass().getModule().getName() != null){
    this.bootstrapServiceLoader = ServiceLoader.<IMixinServiceBootstrap>load(IMixinServiceBootstrapHack.class, this.getClass().getClassLoader());
}else{
    this.bootstrapServiceLoader = ServiceLoader.<IMixinServiceBootstrap>load(IMixinServiceBootstrap.class, this.getClass().getClassLoader());
}

In theory I don't need that check, but better safe than sorry here.

AzzyypaarasTeam04:13
Replying toJack PapelMaybe earlier yet
Jack PapelTeam04:14
gudenau04:15
You can change those.
Try the system look and feel.
AzzyypaarasTeam04:16
Better idea: I make custom icons that actually look good because oh gods that is crusty
gudenau04:16
Similar process.
Just a different look and feel.
Jack PapelTeam04:17
The icons have to be this size btw, it won't scale it automatically
I tried putting the paradise lost icon in there and the window was massive
AzzyypaarasTeam04:17
Resize it manually
Do it
gudenau04:17
You should be able to do that in code.
AzzyypaarasTeam04:18
Solution: rewrite this as an electron app
Jack PapelTeam04:18
Replying togudenauYou should be able to do that in code.
"You" as in someone who actually knows swing, maybe
Being called InstallerGUI, it would be nice if it actually installed the mod for you
AzzyypaarasTeam04:18
Replying toJack Papel"You" as in someone who actually knows swing, maybe
To be fair, you are pursuing CS, and half of CS is figuring shit out
AzzyypaarasTeam04:18
Replying toJack PapelBeing called InstallerGUI, it would be nice if it actually installed the mod for you
What does it currently do?
Jack PapelTeam04:18
I did a little bit of figuring out, but resizing images evades me
AzzyypaarasTeam04:19
Imho the ideal would be it being able to install fabric and AR

gudenauPinned04:19

Something something

BufferedImage source = ImageIO.read("farts.png");
BufferedImage dest = new BufferedImage(64, 64, BufferedImage.FORMAT_4BYTE_ARGB);
var graphics = dest.createGraphics();
try{
    dest.drawImage(source, 0, 0, 64, 64, 0, 0, source.getWidth(), source.getHeight(), null);
}finally{
    graphics.destroy();
}

Or something.

AzzyypaarasTeam04:19
...and with fabric I mean floader and fapi
Basically the installer should do all the installing little timmy needs to go from vanilla to facing lovecraftian abominations while riding a moa
gudenau04:20
Swing should support DPI scaling now.
AzzyypaarasTeam04:20
"farts.png"
brap 😳 🥴
Jack PapelTeam04:21
This is what it does in my not-yet-pushed commit
AzzyypaarasTeam04:21
Ah
Jack PapelTeam04:21
It did a similar thing before but with a different icon and it said "The Aether"
AzzyypaarasTeam04:21
Yeah that sounds like an @kalucky0 moment
Make the tray icon be the PL logo
Jack Papel pinned a message. 04:22
Jack PapelTeam04:22
Replying togudenauSomething something BufferedImage source = ImageIO.read("farts.png"); BufferedImage dest…
pinning this for later
AzzyypaarasTeam04:22
Gud is now the official random programming knowledge fountain
@gudenau this is an obligatory rank, now put on the cat maid programmer dress
gudenau04:22
That isn't 100%, but it was from memory.
No.
AzzyypaarasTeam04:23
Replying togudenauNo.
https://tenor.com/view/cope-seethe-mald-tf2-team-gif-23466119
Jack PapelTeam04:23
Tbh the cat maid dress is one of the weakest femboy outfits
They're always too baggy and look uncomfortable
AzzyypaarasTeam04:23
True true
Jack PapelTeam04:24
It's like gay but not in a gay way
AzzyypaarasTeam04:24
Now, thigh highs + oversized sweater
AzzyypaarasTeam04:24
Replying toJack PapelIt's like gay but not in a gay way
It is straight
very crin
Jack PapelTeam04:24
Replying toAzzyypaarasNow, thigh highs + oversized sweater
^
or crop top
cr24Team04:26
gudenau04:26
I have been using Java for over a decade, how would I not know about AWT? :V
AzzyypaarasTeam04:26
Replying tocr24:huh:
AzzyypaarasTeam04:27
Replying togudenauI have been using Java for over a decade, how would I not know about AWT? :V
In other words, you've been using java for longer than half the people playing this game have been alive
Jack PapelTeam04:27
Depending how much more than a decade, possibly more than the lead dev has been alive
AzzyypaarasTeam04:28
Replying toJack PapelDepending how much more than a decade, possibly more than the lead dev has been alive
iirc he is not that much older than me, so he would have needed to start coding java since he was babbeh
Jack PapelTeam04:29
Not impossible 🤷‍♀️
gudenau04:29
I started when I was like, 12 or so.
AzzyypaarasTeam04:30
Suckling on the tit while cursing the java devs for half of every design decision they've made
gudenau04:36
Alright.
I am now modifying mixin during runtime.
kalucky0Team07:33
Replying toAzzyypaarasYeah that sounds like an @kalucky0 moment
I haven't touched the code for months
AzzyypaarasTeam07:38
Replying tokalucky0I haven't touched the code for months
big kal moment
kalucky0Team07:39
I haven't touched your spaghetti
tbf I'm retiring soon. Two more gigs and I'm ending my programming career
AzzyypaarasTeam07:55
Jack PapelTeam16:16
Replying tokalucky0I haven't touched the code for months
InstalledGUI hadn't been modified for almost a year until yesterday
I think git blame blamed CyaCal