mod-dev-talk Saturday 11 September 2021

53 messages3 people

gudenau00:02
There is sooo much that needs to change, but it's all very similar.
I should be able to reduce some of the data that is sent as well.
So in theory you can update all of the vanilla weather in around 16 bytes instead of like 50, still feels large.
We really need to move the aether up to the max limit, but I don't feel like changing all the world gen.
I am using a TriConsumer here. I am so confused.
AzzyypaarasTeam00:10
:conc:
gudenau01:20
Sometimes I wish you could take a Set<Entry<A, B>> and do .forEach((a, b)->{})
AzzyypaarasTeam01:21
Replying togudenauSometimes I wish you could take a Set<Entry<A, B>> and do .forEach((a, b)->{})
Dw, at the pace java is going that will be a thing by 2040

Doubtful.

Best you could do is something like:

public static <A, B> void biForEach(Set<Entry<A, B>> set, BiConsumer<A, B> action){
    set.forEach((entry)->action.accept(entry.getKey(), entry.getValue()));
}

biForEach(set, (a, b)->{});

Which isn't awful.

I suppose with extensions you could do the forEach thing.

gudenau01:45
10 errors left.
gudenau02:02
I did disable some stuff.
AzzyypaarasTeam02:06
Replying togudenauan attachment
gudenau02:06
What?
I changed how this weather system worked, it created like 50 errors.
AzzyypaarasTeam02:07
It was in reference to the unkown enum constant thing
gudenau02:08
Oh.
Yeah that's just a warning that this project generates.
Always has for me.
AzzyypaarasTeam02:10
huh
gudenau02:16
I think it might be done, minus one thing.
Of course, all worlds that used the old weather system will have their weather reset.
And it crashes on startup.
AzzyypaarasTeam02:17
Replying togudenauAnd it crashes on startup.
minor detail
gudenau02:18
I might end up having to write my own tag implementation.
Which would suck.
For now, I can just do this in a stupid way.
AzzyypaarasTeam02:18
The stupid way is the best way :3

gudenau02:20

        var biomes = switch(controller.getIdentifier().toString()){
            case "the_aether:rain" -> Set.of();
            case "the_aether:snow" -> Set.of();
            case "the_aether:thunder" -> Set.of();
            case "the_aether:thunder_snow" -> Set.of();
        };

gudenau02:27

https://tenor.com/view/fist-pump-kid-happy-celebrate-victory-gif-5228605

java.lang.NullPointerException: Cannot invoke "java.util.Map$Entry.getValue()" because "entry" is null
    at net.id.aether.world.weather.ClientWeatherController.has(ClientWeatherController.java:70)
    at net.minecraft.client.render.WorldRenderer.handler$znl000$renderWeather(WorldRenderer.java:5332)

gudenau02:39

Well that's not right.

var biomes = switch(controller.getIdentifier().toString()){
    case "the_aether:rain", "the_aether:thunder" -> Set.of(
        AetherDimension.HIGHLANDS_PLAINS,
        AetherDimension.HIGHLANDS_FOREST,
        AetherDimension.HIGHLANDS_THICKET,
        AetherDimension.WISTERIA_WOODS,
        AetherDimension.CONTINENTAL_PLATO,
        AetherDimension.HIGHLANDS_SHIELD
    );
    case "the_aether:snow", "the_aether:thunder_snow" -> Set.of(
        AetherDimension.AUTUMNAL_TUNDRA
    );
    default -> throw new IllegalArgumentException("Unknown controller: " + controller.getIdentifier());
};

@Azzyypaaras

AzzyypaarasTeam02:46
o
That
sounds
greatly scmhanfcym
The time for freezing rain is swift approaching
G
gudenau02:47
Fixed.
- 👀1
AzzyypaarasTeam02:48
Most lovely
gudenau02:57
@Azzyypaaras Perfect!
AzzyypaarasTeam02:58
Replying togudenau@Azzyypaaras Perfect!
gudenau02:59
If you check my last commit you will see what I messed up.
AzzyypaarasTeam03:03
Replying togudenauIf you check my last commit you will see what I messed up.
sus
gudenau03:10
That enum doesn't exist anymore.
Jack PapelTeam15:29
Replying toAzzyypaarashuh
Can confirm, I also get that message