mod-dev-talk Thursday 1 July 2021

194 messages8 people

Jack PapelTeam00:31
Working on a huge swet overhaul to allow for the proposed changes
SweepSwap00:50
Replying toJack PapelWorking on a huge swet overhaul to allow for the proposed changes
that is mega epico
you are very epic Jack Papel
Jack PapelTeam01:28
Long story short, Color will be a property of the swet, rather than having different entities for different types
Which should allow for much more versatility
And swets changing colors
And will fix the issues with all swets requiring the same texture(edited)
cr24Team01:36
so we need a white one
as the base texture
?
Jack PapelTeam01:42
Yes
And textures for the other colors as well
cr24Team01:43
are we not tinting it though?
if it's white we can just tint it
Jack PapelTeam01:43
Oh yeah I suppose we can tint it
So just white should be fine
cr24Team01:43
i thought thats what you meant
I can do other colors but it'll just be hueshifted pretty much
i'll just do white we can always change it later
Jack PapelTeam01:43
Sounds good
AzzyypaarasTeam01:44
Imho, perhaps hte best system would be some sort of combo
Jack PapelTeam01:44
We can always make an exception if one needs to be dramatically different
AzzyypaarasTeam01:44
Where you have a basic white swet that can be recolored
But that can also take in a texture
cr24Team01:44
fair
AzzyypaarasTeam01:44
May not be too useful for us, but anyone making an addon would appreciate us
Jack PapelTeam01:44
We can always make an exception if one needs to be dramatically different
Oh yeah that's what I meant by this(edited)
Jack PapelTeam01:54
Oh one small problem on the people-making-addons front
The color has to be an enum, which can't be mixin-ed to
At least not easily
Haven King01:55
Color for what has to be an enum?
Jack PapelTeam01:56
Color for the swet drops block
Which spawns the corresponding color's swet, so I've used the enum for the swets as well to be simple
Since each swet presumably should have a swet drops block, it makes the most sense to use the same type(edited)
AzzyypaarasTeam02:02
What
Swet drops block?
You mean like the whole idea about swets sticking to stuff?
Haven King02:03
I mean, it doesn't have to be an enum 🙃
AzzyypaarasTeam02:03
Please do explain exactly what you mean with that, I feel like there is a better approach to this
A more flexible to that, and one that lets us have more reusable code.
Jack PapelTeam02:08
I'll look into other options then(edited)
Haven King02:09
A record would probably be suitable.
Jack PapelTeam02:10
I'll look into records(edited)
AzzyypaarasTeam02:11
Replying toJack PapelI'll look into records
waaaaaait
Explain what I said above
Jack PapelTeam02:11
Blockstates like enums, basically
AzzyypaarasTeam02:11
bruh
What is the swet drops block
Jack PapelTeam02:11
Oh I see
It's the "swets sticking to trees/other things" idea as a block
since constantly having entities be on the trees would be bad
For performance
AzzyypaarasTeam02:12
Ah
Ok so what I was expecting
Would it not be better to split them and make the block not be specific to swets
That is, make the Swet drop block just a generic spawn entity on break block
And have one of its parameters be a function with which to spawn an entity
Jack PapelTeam02:14
Hm
AzzyypaarasTeam02:14
Basically, instead of doing new SwetDropBlock(pissAndShit) you have EntityDropBlock(pissAndShit, BiFunction<BlockPos, ServerWorld>)
You get what I am talking about right?
Jack PapelTeam02:14
I see
AzzyypaarasTeam02:15
Basically, lets not hardcode things where they don't need to be hardcoded
Jack PapelTeam02:16
I see
Haven King02:18
It should be a BlockEntity storing the entities tag, yes.
Jack PapelTeam02:20
When I'm back at my computer I'll make these changes
AzzyypaarasTeam03:03
Replying toHaven KingIt should be a BlockEntity storing the entities tag, yes.
What? No
Why would it need to be
That is an unnecessary performance sink
Haven King03:03
What? No it's not.
If a swet turns into a block with half a heart and poison, then turns back into a swet, it should still have half a heart and poison.
Besides, block entities in 1.17 don't tick unless you explicitly have them do so. It's just a way to store data.
AzzyypaarasTeam03:04
What
Swets can't just turn back into a block
This is a one way ordeal
Haven King03:05
Oh?
AzzyypaarasTeam03:05
Block > entity
Not the other way around
Only exception I could perhaps think of is white swets maturing, but since it is infant > adult they should get a full heal either way
Haven King03:05
It still needs to be a Block Entity to at least store the swet type.
cr24Team03:06
what about blockstates
afaik block entities are laggier(edited)
Haven King03:06
They're really not.
cr24Team03:06
although it couldn't be expanded on
Haven King03:06
Definitely don't use blockstates.
AzzyypaarasTeam03:09
We can do neither of htem
Just
Make a new block for each type of entityu want to spawn
cr24Team03:10
THIS
Haven King03:13
No, why would you do that?
Jack PapelTeam03:21
Replying tocr24what about blockstates
This is what I was going for originally
But yes the other ideas do seem more versatile
AzzyypaarasTeam03:28
Replying toHaven KingNo, why would you do that?
You have a very simple, very clean implementation where you just make a new block and feed it a function
Rather elegant given it has one, simple purpose
Or you make an entire fucking BE for a block that you could get hundreds of in a block depending on the situation
Haven King03:32
I don't know why you think a BE is harder to make than a block
With the BE you don't even need to pass a function and make new instances
You literally would have one BE type that automatically supports every single possible type of Swet(edited)
Jack PapelTeam03:42
Both solutions sound reasonable to me, so I'll let you guys discuss this a bit more
Though passing a function as an input seems a bit overkill since all you need to do is spawn a certain entity
AzzyypaarasTeam03:54
Replying toHaven KingYou literally would have one BE type that automatically supports every single possible…
Yes yes but I ask you
Is this cleaner?
Haven King03:54
Yes.
Because you're not registering a different number of blocks based on which mods are loaded.
AzzyypaarasTeam03:55
Replying toHaven KingBecause you're not registering a different number of blocks based on which mods are…
What?
Sorry how did you get to that conclusion, exactly?
Haven King03:55
If another mod added a new kind of swet, it would need a new block. That's kinda silly when all they want is an entity.
AzzyypaarasTeam03:55
Are we having bloody compat swets now
Haven King03:55
Wasn't that what started this conversation?
AzzyypaarasTeam03:56
Somewhat, but that is kind of a misuse of the argument
If someone wants to do that then they can just register a new block
Haven King03:56
Even so, having one block entity is certainly cleaner than having a potentially large number of blocks.
AzzyypaarasTeam03:57
Sorry for not being a fan of cramming a shitton of code into one BE
Haven King03:57
It's not even a shitton of code?
cr24Team03:57
wait are you not kidding @Azzyypaaras
lol
AzzyypaarasTeam03:57
:3
cr24Team03:58
i literally can't tell if you're joking
AzzyypaarasTeam03:58
Listen, while it is not perhaps a lot of code
You are still making something dynamic that just does not need to be
If you just make it a block with a function to handle it then that is a static thing, it is initialized and it is done, all blocks call the one function, it is simple
It is also versatile as if you want to do a similar effect with lets say spiders then you can use the same block
Haven King03:59
I mean, nothing needs to be dynamic. We should have a different block for every single mob spawner too /s
AzzyypaarasTeam03:59
Ah yes, strawmen
Haven King03:59
That's not a strawman it's the exact same argument(edited)
AzzyypaarasTeam04:00
You are taking the argument and exaggerating it to a nonsensical point while removing the context
That is absolutely a strawman
By that logic I could say that we should replace every block that works even remotely similarly and compress them into one block using BEs
Archanum04:01
I think since only one of the available types of swets is gonna be spawned this way, simply for the tree thing, doesn't making it a block make more sense? Even if we have 100 different types of swets, it's still only the golden one going to be using this function, right?
AzzyypaarasTeam04:02
Replying toArchanumI think since only one of the available types of swets is gonna be spawned this way…
Golden ones are the only ones currently planned, however something I have noted already is that such a block could be reused in various scenarios
Eg: spiders bursting out of a sack when broken
However, that does not necessitate a BE
A block entity ought not to be a default thing, it is not the first thing one should think of
It is a tool to be used when something is not reasonably and or cleanly achievable through a plain block.
In this case, this can absolutely be done elegantly simply via blocks.
Thus, no need to overcomplicate things
Crackers010604:18
wait what's this about?
swets spawning from a block?
wouldn't you just make something similar to infested silverfish blocks?
Jack PapelTeam04:19
the spawning-from-a-block part isn't the hard part
It's how the block should know what to spawn
Because ideally, this one type of block should be able to spawn any kind of swet specified
With the blockstates method, it's really easy to change the way the block looks for different swet types, but it also restricts the block quite a bit
With the BlockEntity method, it's perhaps overcomplicated(edited)
With the pass-in-a-function-as-a-parameter method, it's perhaps a bit clunky
Jack PapelTeam07:02
I've looked into it, and it seems like the BlockEntity method is the one of choice(edited)
AzzyypaarasTeam07:07
Jack PapelTeam07:08
the pass-in-a-function method doesn't seem like it'd make it easy to change the block's texture based on the type of swet(edited)
AzzyypaarasTeam07:09
Just make the texture different, if you are using separate blocks then that is already a requirement
That also, as aforementioned, makes it easy to then reuse this for non-swet entities, such as spiders or items
Imagine a zelda-like pot for the later
Jack PapelTeam07:10
Oh yes I'm tired and not speaking straight. Let me edit my message
AzzyypaarasTeam07:11
huh?
You know I just thought of another issue relating to the BE idea that uh, I don't think anybody thought of
Putting these in the creative inv is going to be interesting, it will require at least a custom item
Jack PapelTeam07:12
hm yeah
Jack PapelTeam07:12
Replying toAzzyypaarasThat also, as aforementioned, makes it easy to then reuse this for non-swet entities…
Both methods would allow for any entity type(edited)
AzzyypaarasTeam07:13
Yes, but one is more conductive to changing the whole texture rather than just the color
Even the model can be changed, for that matter
Jack PapelTeam07:13
I see
AzzyypaarasTeam07:14
As a matter of fact, the different model thing could be of interest for swets too
Why would a golden swet stick to a tree in the same way a purple one hangs from the wall of a dungeon?
Jack PapelTeam07:14
Instead of passing a function, would it not be just as effective as just passing in the entity type? Since that's the only thing that would change
Jack PapelTeam07:14
Replying toAzzyypaarasWhy would a golden swet stick to a tree in the same way a purple one hangs from the wall…
Good point
AzzyypaarasTeam07:15
The reason I said function instead of entity type is that a function is more flexible
Particularly a bifunction
Give me the world and pos and you can do a lot, particularly since the world then gives you access to random and things start to get fun
Jack PapelTeam07:16
Oh I hadn't considered that
AzzyypaarasTeam07:16
Just throwing entity type at it would, however, also work
Depends on just how much you want to get from the one class
I say a BiFunction<BlockPos, World> is a good compromise
Jack PapelTeam07:17
I just checked my github desktop and realize I undid half the work I did today
Gah
AzzyypaarasTeam07:17
oof
Perhaps you ought to rest and continue work later
Jack PapelTeam07:17
Well now I got the experience to make it again haha
yeah I'll rest for now
AzzyypaarasTeam07:18
I am off to sleep myself, 'twas a good day today
Made a tiny bit of progress on TTLG, drew some booba, finally got to work on a magic mod idea I had been preparing for a while
I even got around to being half productive 'round these parts
Jack PapelTeam07:19
Awesome
Hey have a nice night
AzzyypaarasTeam07:19
You have a good... uh
!timezone
what was the command
tz.help
World TimeBot07:19
Help & About
World Time v1.3.3 Serving 5951 communities across 389 time zones.
Commands
tz.help - This message. tz.list - Displays current times for all recently active known users. tz.list [user] - Displays the current time for the given user. tz.set [zone] - Registers or updates your zone with the bot. tz.remove - Removes your name from this bot.
Admin commands
tz.setFor [user] [zone] - Sets the time zone for another user. tz.removeFor [user] - Removes another user's information.
Zones
This bot accepts zone names from the IANA Time Zone Database (a.k.a. Olson Database). A useful tool to determine yours can be found at: https://kevinnovak.github.io/Time-Zone-Picker/
AzzyypaarasTeam07:19
tz.list
World TimeBot07:19
● 30-Jun 23:19 AKDT (UTC-0800): fishy#0165 ● 01-Jul 00:19 PDT (UTC-0700): Jack Papel#8773, Haven King#2790 ● 01-Jul 02:19 CDT (UTC-0500): varinyc#5066, Azzy (azazelthedemonlord#2563), CDAGaming#3162, 24Chrome#1098 ● 01-Jul 03:19 EDT (UTC-0400): nailuj29#4242 ● 01-Jul 04:19 -03 (UTC-0300): Moises#4148 ● 01-Jul 09:19 CEST (UTC+0200): kalucky0#9373
AzzyypaarasTeam07:19
Ah
gn it is then
Jack PapelTeam07:20
I gotta check out at 8 tomorrow, don't get the impression that I'm an early bird lol
Alright gn
AzzyypaarasTeam07:20
:3
Crackers010614:50
@Jack Papel https://github.com/Crackers0106/The-Aether/issues/24
GitHub
Add Skyroot and Holystone tool abilities · Issue #24 · Crackers0106...