mod-dev-talk Wednesday 23 June 2021

183 messages9 people

Jack PapelTeam05:50
SIX
All results from github were from other 1.17 fabric mods
None had any solution nor ideas
Frqnny05:57
that happens in vanilla with nether ruin portal
really its pretty hard to check
inside a ChunkRegion#setBlockState it checks if its setting inside the prescribed boundaries
i wish it let you check that before placing so you’d avoid the errors
LudoCrypt05:59
whats the error
Jack PapelTeam06:00
Replying toFrqnnyinside a ChunkRegion#setBlockState it checks if its setting inside the prescribed…
Thanks for the help, I'll see what I can do with this information
Frqnny06:01
the method it checks for is unnamed
and it uses Utils to error
dont remember much else
Jack PapelTeam06:16
Seemingly there's not much I can do(edited)
After a further review, there is seemingly nothing at all I can do.(edited)
CDAGamingTeam06:28
Is there a way a sanity check could be added to ensure setBlock doesn't occur outside a certain distance
Wouldn't that fix it?
Jack PapelTeam06:29
Maybe
I'll try that out
CDAGamingTeam06:31
As the error itself is basically saying, setBlock was used at x,y,z, but the position we're currently generating at is a,b,c So logically, the best case is adding sanity checks to ensure setBlock is only executing where we want it too
Jack PapelTeam06:41
I added a check so that it wouldn't generate more than 10 blocks from the origin of generation, and the error still came up
oh wait
I misread
one moment
Jack PapelTeam06:55
Ok
So
I restricted setblock for quicksoil and aerclouds to within 10 blocks of their origin
and it fixed the issues
one problem
The fallen leaves feature is based on minecraft's own methods
so I can't do the same restrictions for those
and they also cause the same error in the console(edited)
CDAGamingTeam06:58
O.o How do they not error in normal MC generation in that case?
Jack PapelTeam06:59
Beats me
Easiest solution might just be to mixin and remove the statement that logs it to the console 😅
CDAGamingTeam07:01
True, but that's more like a bandaid, especially if it's used in a larger scope
Recall the fact that 1.12.2s aether legacy had cascading lag that never was truly fixed bc it was bandaided over time(edited)
Archanum07:03
Does the setblock issue happen to a newly planted tree, versus one that was generated there?

CDAGamingTeam07:04

It only happens during feature generation, not to manually placed stuff

[22.06 22:29:25] [Server] [Worker-Main-10/ERROR]: Detected setBlock in a far chunk [-22, -51], pos: class_2338{x=-345, y=127, z=-801}, status: minecraft:features, currently generating: ResourceKey[minecraft:worldgen/configured_feature / the_aether:cold_aercloud]

This is one of the lines, but spammed hundreds of times when it occurs

Archanum07:05
Then could you grow trees instead of generate them, during feature generation? Is there a difference there
Jack PapelTeam07:05
Can't really extend that to aerclouds and quicksoil anyway
Archanum07:06
But maybe someone who makes a worldgen mod would know?
LudoCrypt07:07
code?
Haven King07:09
Features are limited to a 3x3 chunk area centered around the chunk they initially generate in.
That is one reason cloud generation is difficult. You cannot make them very large. I imagine when Azzy changed cloud generation, he didn't account for that limitation 🙂
LudoCrypt07:10
Replying toHaven KingFeatures are limited to a 3x3 chunk area centered around the chunk they initially…
is there any way to create a feature larger than that area? Like can structures do that or hm?
CDAGamingTeam07:10
Replying toHaven KingThat is one reason cloud generation is difficult. You cannot make them very large. I…
This theory can actually be tested with "genType": "legacy" in the data pack as I added support for generating the legacy clouds(edited)
Haven King07:11
Replying toLudoCryptis there any way to create a feature larger than that area? Like can structures do that…
Structures have a larger area, 5x5 chunks IIRC? I could be wrong though, it might be even larger.(edited)
LudoCrypt07:11
anything larger than 5x5
Haven King07:11
Nope.
LudoCrypt07:11
can i mixin into that range somehow i want to make features 60 chunks big (theoretically 😉)
jk
Haven King07:11
No, the world would simply fail to generate.
You could maybe increase it by like one or two without any horrible consequences? 60 would be a lot though.
CDAGamingTeam07:13
https://cdn.discordapp.com/attachments/770723749565300798/854075492206379048/AetherLegacyGen.zip This is the legacy data pack for reference for testing(edited)
LudoCrypt07:13
yeah im sure 60 is too much but, how do features like that actually generate? Does each thing like check each chunk for features in a 3x3 radius or like whats up with that
Jack PapelTeam07:14
Ah I think I can see the fix for fallen leaves now
Archanum07:14
Show and tell time, class. (edited)
Jack PapelTeam07:15
the spread is set to 21, but should be set to at maximum 16 so that if the initial position is at a chunk boundary, it won't generate outside the 3x3 chunk zone
Haven King07:15
Replying toLudoCryptyeah im sure 60 is too much but, how do features like that actually generate? Does each…
What do you mean?
Jack PapelTeam07:15
assuming spread is radius or manhattan radius
CDAGamingTeam07:15
O.o Ooh
LudoCrypt07:15
i just dont know how features actually generate
but thats okay idrc
Jack PapelTeam07:15
does anybody?
CDAGamingTeam07:15
^^ this
LudoCrypt07:15
i think itd be cool to increase the range though
Archanum07:15
Oh i do!
Haven King07:15
Each feature is generated in each and every chunk if it can generate in that biome.
Archanum07:16
Make all the clouds structures then
CDAGamingTeam07:16
We just bend to our overlords at Mojang 😛
LudoCrypt07:16
Oohh actually
what if you like used simplex noise for generating clouds
Haven King07:16
DecoratedFeatures are wrappers around features that make them generate more sparsely and sporadically.
Haven King07:17
Replying toLudoCryptwhat if you like used simplex noise for generating clouds
To get it to be at all performant you'd want a custom ChunkGenerator that can handle that. Speaking from experience, custom chunk generators are painful.
LudoCrypt07:17
oh yeah
im not experienced in chunk generators but all ive really done are mazes
not even good mazes
CDAGamingTeam07:18
We also migrated off of a custom chunkgenerator, and i dont think anyone on the team wants another scenario of spagetti code xD
Haven King07:18
No, I threw that thing out for a reason.
CDAGamingTeam07:18
The horrors of that 1.14 chunkgenerator is stuff I never want to experience for awhile xD
Haven King07:18
Carvers could theoretically be used to make clouds using simplex noise, but carvers are also painful.
LudoCrypt07:18
well technically you could just have a feature that generates at the corner of every chunk and then use simplex noise to generate clouds
Archanum07:18
This must be where all the space garbage is falling from
Jack PapelTeam07:18
Replying toJack Papelthe spread is set to 21, but should be set to at maximum 16 so that if the initial…
misread, this actually fixes the error with aether brush. still don't know how to fix leaf piles. but at least I fixed the brush
Haven King07:19
Replying toLudoCryptwell technically you could just have a feature that generates at the corner of every…
Yeah, features are relatively slow though.
CDAGamingTeam07:19
Replying toJack Papelmisread, this actually fixes the error with aether brush. still don't know how to fix…
nice 😄
Haven King07:20
Because they have a 3x3 chunk area available to them, while they're generating they actually lock all nine of those chunks. Chunk generators and carvers, on the other hand, only have one chunk of access/locking, so they are much faster.
Jack PapelTeam07:20
Oh boy my computer is on 5%
I'll pick this up tomorrow
CDAGamingTeam07:22
Nice job so far 😄
Jack PapelTeam07:23
Thanks
Honestly when I started i thought there was no way I was going to make a dent in this problem, but I've learned a lot
CDAGamingTeam07:24
Hey, it's better we're dealing with this hurdle now rather then later when it becomes a bigger snowball 😄
Solving the problem before it becomes a problem 😎
CDAGamingTeam21:00
@cr24 Implemented your suggested fix for calculateIncrease, test it in SP and let me know if it fixes it
If it does, ill push it to the server
cr24Team21:00
I'm at work i cannae test it for another hour
CDAGamingTeam21:00
Ah, ok
cr24Team21:01
Since i code in java for work tho i'm going to test it lol
already have the software open i'll just run the function
CDAGamingTeam21:03
Sweet
cr24Team21:03
oh shit lol
i figured out why it was instamining
return (float) tool.getMaxDamage() / tool.getDamage() / 50;
if the damage is 0 (undamaged) you get infinity bc of division by zero
🤔
CDAGamingTeam21:05
O.o
cr24Team21:05
zanite gets faster with lower health?
or is it the other way

CDAGamingTeam21:05

Lemme check GG's calculation

    public float calculateIncrease(ItemStack tool) {
        int current = tool.getDamageValue();
        int maxDamage = tool.getMaxDamage();
        
        if (maxDamage - 50 <= current) {
            return 7.0F;
        }
        else if (maxDamage - 110 <= current) {
            return 6.0F;
        }
        else if (maxDamage - 200 <= current) {
            return 5.0F;
        }
        else if (maxDamage - 239 <= current) {
            return 4.0F;
        }
        else {
            return 3.0F;
        }
    }

(edited)

Jack PapelTeam21:08
is getDamageValue() zero when the tool is undamaged or equal to getMaxDamage()?
cr24Team21:08
faster with better durability
get damage is current damage with high=better
I think
Jack PapelTeam21:08
gotcha
CDAGamingTeam21:09
I'll probably just use the GG method, since our call is doing stuff completly different xD
cr24Team21:09
unless damage is the amount of damage taken
and not the current health
yeah use theirs
CDAGamingTeam21:10
Pushed, deploying to server in a few minutes
Also legit every time an aether post is in showcase, It's immediatly followed by a car 🤣
J
Jack PapelTeam21:15
I've gotten quicksoil and aerclouds sussed out, right now it's just fallen leaves giving me trouble(edited)
- 🇸2
- 🇺2
- 🈂️2
CDAGamingTeam21:16
xD Getting closer at least 😄
Jack PapelTeam21:29
I can't seem to find where the radius of the fallen leaves pile is in code
if there is one
cr24Team21:29
it's probably on the json side
nope i was wrong
Jack PapelTeam21:33
Hold on I think I may have something
I did not have something
cr24Team21:45
lol
Jack PapelTeam21:46
I figured out *i think* how to change the radius
but it still did not work
Jack PapelTeam21:58
Fixed* fallen leaves
Turns out I hadn't fully fixed aerclouds so I'll do that
CDAGamingTeam22:02
Nice xD
Jack PapelTeam22:02
Wonderful news
Got everything worked out as far as I can tell
Except rainbow fallen leaves, but they don't generate at the moment anyway afaik
CDAGamingTeam22:04
Sweet, PR it and I'll deploy it to the server 😄
Jack PapelTeam22:04
Alright
Fallen leaves spawn less frequently now btw
CDAGamingTeam22:04
That should be fine for the most part
Jack PapelTeam22:08
Glad I could get that one done 😄
CDAGamingTeam22:08
Merged 😄 Deploying to server in a few moments
@Jack Papel I saw you join right as i hit reboot xD
Jack PapelTeam22:13
lol
I think I'll make another pr later that does things in chebyshev distance
I got a meeting at 4 ish, so it'll be soon after then
CDAGamingTeam22:19
Detected setBlock in a far chunk [15630, 15617], pos: class_2339{x=250080, y=39, z=249873}, status: minecraft:features, currently generating: ResourceKey[minecraft:worldgen/configured_feature / the_aether:rainbow_fallen_leaves]
Apparently sodium crashes if i TP over a large distance xD
ColdFlame5322:26
Ahh good ol sodium
CDAGamingTeam22:27
Hehe, but the other fixes worked perfectly xD
So now once the rainbow leaves get a pr, everything's set to go 😄
Jack PapelTeam23:28
Did the blue aercloud changes
It doesn't bounce you exactly to the same height, but it's better than slime blocks
I made sure that you couldn't slowly increase your bounce over time
AzzyypaarasTeam23:32
Replying toJack PapelI made sure that you couldn't slowly increase your bounce over time
lame
Time for a new redstone device
Jack PapelTeam23:33
Thanks for taking care of the rainbow leaves for me CDA
cr24Team23:35
Replying toAzzyypaarasTime for a new redstone device :yeefuckinhaw:
But what about the mobs
CDAGamingTeam23:37
Happy to do so 😄
Also, I'm going to be lifting the whitelist an hour early, but won't announce the server details until 8PM CST
Mainly so I can open the flood gates here first, and be able to shut them if instability starts showing up
Confirmed the fix for the rainbow leaf piles too, so we're all set to go xD
19 minutes until I unleash the flood!
Gonna merge in the blue aercloud changes as well
AzzyypaarasTeam23:45
Real quick
Jack noted that rainbow leaf piles are not generating
So I must ask
CDAGamingTeam23:45
I fixed that
AzzyypaarasTeam23:45
Are wisteria woods dead again?
Ah
CDAGamingTeam23:45
Jack didnt know they spawn in wisteria woods xD
AzzyypaarasTeam23:46
CDAGamingTeam23:46
Also as of now, the critical worldgen issues are fixed too, so no more log spam
AzzyypaarasTeam23:46
CDAGamingTeam23:46
In 15 minutes, the server testing is gonna get a lot more intensive xD
You think we could do an everyone ping for it's announcement, Azzy?(edited)
AzzyypaarasTeam23:50
perhaps
CDAGamingTeam23:50
I put the queued announcement I have planned in staff chat, but yea I think this is worth the ping xD