mod-dev-talk Monday 21 December 2020

91 messages7 people

XenialJesse00:01
Not a big deal but AR + Dawn API crashes MC before it starts. Dawn is used for a very small biome mod and a couple of other things. https://www.curseforge.com/minecraft/mc-mods/dawn
crash-2020-12-21_07.56.38-client.txtText file, 10 KB. Not stored in the archive.
Just data for later if it continues to matter
Deleted User00:06
Dawn will 100% not be compatible with any other biome creating mod. They use so many mixins (hacky shit) to rewrite the entire vanilla biome system. No mod that works with overworld/new dimension biomes will work with dawn.
Haven King00:06
This particular problem looks like it can be fixed though.
As it's a result of Azzy's hacky overwrite
Speaking of which, @Azzyypaaras what is this supposed to do? https://github.com/devs-immortal/The-Aether/blob/master/src/main/java/com/aether/mixin/render/BackgroundRendererMixin.java(edited)
Deleted User00:07
It will be a miracle anyways to get it working alongside dawn 👀 @Haven King
I think its to fix the fog when you're underwater. Eg: remove the murkyness of the water and make it clear when you are underwater
Haven King00:09
What..? Why?
Deleted User00:10
Idk
Make it look like this? https://c.tenor.com/QSSfCOQH_SgAAAAM/water-crystal-clear.gif
IMS00:11
petition to make a mod that makes water look realistic and like that
Deleted User00:11
Shaders exist bro
IMS00:11
lol
removing that mixin, this happens
java.lang.NoSuchMethodError: java.nio.ByteBuffer.clear()Ljava/nio/ByteBuffer; at net.minecraft.client.render.BufferBuilder.sortQuads(BufferBuilder.java:1536) at net.minecraft.client.render.RenderLayer.draw(RenderLayer.java:596) at net.minecraft.client.render.VertexConsumerProvider$Immediate.draw(VertexConsumerProvider.java:86) at net.minecraft.client.render.VertexConsumerProvider$Immediate.method_24213(VertexConsumerProvider.java:65)
it crashes as soon as the loading screen panorama loads
so quite a bit after start but not in game
Haven King00:15
Yeah, no, that's a different issue.
Which I assume happens because you're on Java 9
IMS00:15
it hsould be loading java 8
Haven King00:15
Replying toDeleted UserMake it look like this? https://c.tenor.com/QSSfCOQH_SgAAAAM/water-crystal-clear.gif
Also, that mixin definitely doesn't make the water look like this 😛
IMS00:15
openjdk version "1.8.0_275"
nope
Haven King00:15
Huh
Well either way, I've removed that mixin in my environment and it works 👀
AzzyypaarasTeam00:23
@Haven King Oh yeah that, that... should not be enabled
That was an experimental mixin to play around with fog in the aether, hence it being an overwrite instead of something more sane
Haven King00:23
It looks like somebody disabled my mixin to BackgroundRenderer and enabled yours 🙃
AzzyypaarasTeam00:23
XenialJesse00:24
I'm happy to give up Dawn for AR even in its alpha state, but to be fair on Dawn it was running with 6 other biomes mods
Haven King00:25
Ahah, it was you, Azzy https://github.com/devs-immortal/The-Aether/commit/c8f328fbbdb7937a94c6a6cf1de856eca3433cf0#diff-938773902b9496b4b8412828f652e7cc05c73e962f5143590ade8c235878b0b9(edited)
@XenialJesse Try this build: https://www.mediafire.com/file/k1jnhdf3i2ya2vx/aether-1.16.4-beta.jar(edited)
XenialJesse00:35
Crashes, but much quicker with these messages.
message.txtText file, 5 KB. Not stored in the archive.
Haven King00:36
Looks like you don't have the trinkets API installed
XenialJesse00:36
ohhh
Haven King00:36
Really we should have that listed as a proper dependency, so I'll throw that in there
XenialJesse00:37
.. But I didn't need that for AR before?
Deleted User00:37
@XenialJesse it'll be needed for beta 2.0
XenialJesse00:37
Oh ok
That did it
Good job 🙂
Haven King00:47
Cool, I'll go ahead and push these changes.
XenialJesse04:01
Crashes to desktop, but first saves the game before exiting. Reloading the save causes the crash again immediately, so it's kind of a world-killer. To reproduce I just made a single biome beach and flew around in creative for about 20 seconds. I didn't have to go to the Aether.(edited)
crash-2020-12-21_11.56.59-client.txtText file, 12 KB. Not stored in the archive.
cr24Team04:03
looks like a zombie spawned with some armor on
is armor still broke with geckolib?
XenialJesse04:12
I tried spamming zombie eggs just now and got the crash again after about 30 zombies. Also notable, that was the 2nd game I had to make to try. The first new game I made got the same crash within 5 seconds of starting.
XenialJesse04:20
Checked with the v.1.0.0 jar (as I've been running the beta that Haven King linked me to earlier). Same result from the zombie eggs: eventual crash and can no longer reopen that world.
Haven King04:25
Yes, this is an issue with GeckoLib
Supposedly a fix is being worked on
I'm not sure exactly what that looks like though.
XenialJesse04:38
uff :/
Lol.. I disabled the mod and loaded the game. You can see the culprit... and all his dead brethren. XD
I'd call him Thanos, except Thanos didn't kill everyone
XenialJesse04:53
Oh.. I see. Armour in 3rd person, whether it's me or zombie or an elytra.. All the same geckolib/Fabric bug I guess.(edited)
fishy04:54
tmw you install a mod and it renders the game unplayable(edited)
Haven King05:17
One mixin to ~~FAPI~~ GeckoLib later:(edited)
@XenialJesse Here's a build that fixes the armor thing: https://www.mediafire.com/file/k1jnhdf3i2ya2vx/aether-1.16.4-beta.jar(edited)
AzzyypaarasTeam05:24
Replying toHaven KingOne mixin to FAPI GeckoLib later:
You should PR that to geckolib
Haven King05:25
See, I should
Buuut
AzzyypaarasTeam05:25
No butts
This is not a hentai
Haven King05:26
Fiiine
Actually, I'm just gonna ping Gecko
XenialJesse05:34
Oh great, I'll try that in a min
I don't know what I'm doing so I download the latest geckolib (because I don't know what I'm doing) and tried that
Just because it was updated more recently than some post of a geckolib guy saying it'll be updated soon
It didn't make a difference to the crash at all. But I could not get an armoured zombie to spawn. Not after about 20 minutes of sitting there just holding right click and flying around while watching Youtube
And the babies were spawning wayyyy more than the adults
Haven King05:37
Yeah, I can confirm it's still not fixed in the newest version.
XenialJesse05:37
and no chicken jockeys at all
yeah
Haven King05:37
Replying toXenialJesseAnd the babies were spawning wayyyy more than the adults
Baby zombies spawn if you click on the same space as an adult zombie
XenialJesse05:37
ohhhhhh
That explains that lol
Haven King05:38
Yep hahahahaha
X
XenialJesse05:38
Ok I'll give your AR file a go
- 👍1
Haven King05:45
@Azzyypaaras There you go. I put the minimal amount of effort in: https://github.com/bernie-g/geckolib/pull/59(edited)
AzzyypaarasTeam05:46
Blessed
XenialJesse06:06
That took me a while to get to, but yep that fixes it.. including the Ely
I see now what the Trinkets thing does. But is there a way to not allow ely + chestplate at the same time? Like a config in trinkets maybe?
Ty for the fixes to things I've raised today 😄
Haven King06:11
That sounds like a design decision for the Trinkets team 😛
But no problem, I like fixing bugs.
XenialJesse06:12
Is there a way to not have it on with AR now though?
Haven King06:12
I'm not really sure, sorry.
XenialJesse06:12
ok, np