#mod-dev-talk Thursday 12 November 2020
41 messages2 people
- KTurns out my implementation of coord scaling isn't broken. I've been scratching my head over it and turns out vanilla nether portals work the same way06:17I thought it had something to do with the scaling math I had, but nope entering the nether through one portal, and returning and ending up in a completely different spot is a vanilla thing06:17I usually play with a mod that fixes that, so it completely blew over my head06:21I'll have it re-enabled in the next build, and I'll add it to my todo list to look into implementing a way to fix this if that's something you're interested in(edited)
- K
- D
- K
- D
- K
- DSomeone in our push-access contributor team want to deal with this? https://github.com/devs-immortal/The-Aether/security/code-scanning(edited)10:54I can, just give me a minute to test my second mixin
- D11:22But I'll do it just for sake of cleanup11:29@Kyrptonaught your portal works like a dream11:35@Deleted User lmfao you made it worse for the security, i'll fix it 😕 lul11:36ok xD11:36It was complaining about implicit casts11:36Not intelliJ https://i.imgur.com/Ft5gKcw.png11:36so I made them explicit11:36Ignore intelliJ lmao11:37intelliJ didn't say anything11:37stop assuming I've done something11:37it's annoying11:37im not lol11:37tbh i would put 3f instead of (float) 311:38that's true11:38Oh nevermind11:38it fixed it11:38github was slow11:38I was just copying and pasting
(float)11:38You can fix the more stupid ones11:39I will now try to fix logs11:39stripped logs, not console logs
