mod-dev-talk Sunday 8 November 2020

80 messages4 people

AzzyypaarasTeam20:46

public void onEntityCollision(BlockState state, World world, BlockPos pos, Entity entity) {
        if (!world.isClient() && !entity.hasVehicle() && !entity.hasPassengers() && ((AetherEntity) entity).canUseAetherPortal()) {
            BlockPos target;
            ServerWorld serverWorld = (ServerWorld) world;
            RegistryKey<World> targetRegKey = world.getRegistryKey() != AetherDimension.AETHER_WORLD_KEY ? AetherDimension.AETHER_WORLD_KEY : World.OVERWORLD;
            ServerWorld targetWorld = serverWorld.getServer().getWorld(targetRegKey);
            if(targetRegKey == AetherDimension.AETHER_WORLD_KEY)
                target = new BlockPos(entity.getX() / 8, entity.getY(), entity.getZ() / 8);
            else
                target = new BlockPos(entity.getX() * 8, entity.getY(), entity.getZ() * 8);
            ChunkPos chunkPos = new ChunkPos(target);
            targetWorld.getChunkManager().setChunkForced(chunkPos, true);
            int y = targetWorld.getTopY(Heightmap.Type.MOTION_BLOCKING_NO_LEAVES, target.getX(), target.getZ());
            targetWorld.getChunkManager().setChunkForced(chunkPos, false);
            if(entity instanceof ServerPlayerEntity) {
                serverWorld.getChunkManager().addTicket(ChunkTicketType.POST_TELEPORT, chunkPos, 1, entity.getEntityId());
                ((ServerPlayerEntity) entity).teleport(targetWorld, target.getX(), y, target.getZ(), entity.yaw, entity.pitch);
            }
        }

The readability of this is swiftly decending to shit

Deleted User20:46
my god
AzzyypaarasTeam20:47
Oh boy, I am not going to be able to sample heightmaps for y
Deleted User20:47
can I make it worse?
AzzyypaarasTeam20:47
Loop time
Give it a shot
Deleted User20:48
Just comment it
/ seperate some lines
AzzyypaarasTeam20:48
no,
Deleted User20:48
social distance the code ;P
CDAGamingTeam20:48
Just put it all on one line
Deleted User20:48
^^^^
AzzyypaarasTeam20:48

Deleted User20:48

do a min.slim.js 😄

Thats 1 line there except the comment

https://i.imgur.com/RgmGNjP.png

public void onEntityCollision(BlockState state, World world, BlockPos pos, Entity entity) {
    if (!world.isClient() && !entity.hasVehicle() && !entity.hasPassengers() && ((AetherEntity) entity).canUseAetherPortal()) {
        BlockPos target;
        ServerWorld serverWorld = (ServerWorld) world;
        RegistryKey<World> targetRegKey = world.getRegistryKey() != AetherDimension.AETHER_WORLD_KEY ? AetherDimension.AETHER_WORLD_KEY : World.OVERWORLD;
        ServerWorld targetWorld = serverWorld.getServer().getWorld(targetRegKey);
        targetRegKey == AetherDimension.AETHER_WORLD_KEY ? target = new BlockPos(entity.getX() / 8, entity.getY(), entity.getZ() / 8) : target = new BlockPos(entity.getX() * 8, entity.getY(), entity.getZ() * 8);
        targetWorld.getChunkManager().setChunkForced(new ChunkPos(target), true);
        targetWorld.getChunkManager().setChunkForced(new ChunkPos(target), false);
            if(entity instanceof ServerPlayerEntity) {
                serverWorld.getChunkManager().addTicket(ChunkTicketType.POST_TELEPORT, chunkPos, 1, entity.getEntityId());
                ((ServerPlayerEntity) entity).teleport(targetWorld, target.getX(), targetWorld.getTopY(Heightmap.Type.MOTION_BLOCKING_NO_LEAVES, target.getX(), target.getZ()), target.getZ(), entity.yaw, entity.pitch);
            }
        }

Tried my best

AzzyypaarasTeam20:50
CDAGamingTeam20:51
Mmm, this be lookin nice
cr24Team20:52
check the new issue i posted
can't even make the farmland on aether dirt
or grass
CDAGamingTeam20:52
Aware of it, both it and bone meal won't really work until feature gen is further along to allow it(edited)
cr24Team20:53
okay
AzzyypaarasTeam21:43
This is fine
Deleted User21:44
Azzy
we need to make mod
called
Broken Portals
AzzyypaarasTeam21:45
👀
CDAGamingTeam21:52
o.o
AzzyypaarasTeam21:53
That's a new one
Deleted User21:57
Dafuq did you do now
AzzyypaarasTeam21:58
Surprisingly, it is actually very difficult to prevent the player from getting stuck in a teleporation pingpong match(edited)
Deleted User21:59
Just add a delay like the nether portal(edited)
AzzyypaarasTeam21:59
real shit
Deleted User21:59
Omfg
Autocorrect
Wtf
cr24Team21:59
hmmm
AzzyypaarasTeam22:00
fuck me it is just what I feared
fuck fuck fuck
When teleporting accross dimensions the game just creates a new player entity goddamit
Deleted User22:00
Stop swearing and say it for fucks sake lul
AzzyypaarasTeam22:01
This is going to be a pain in the ass to deal with
Prepare for jank
Deleted User22:01
Mixins be like brrr
CDAGamingTeam22:07
Surprisingly, it is actually very difficult to prevent the player from getting stuck in a teleporation pingpong match
Yea, I recognize that, that's an oldie from Kinos port too xD
Also yes, the mixin count is growing rapidly, hence why i organized them early on xD
AzzyypaarasTeam22:17
Aether be lookin' funky
AzzyypaarasTeam22:42
platform gen pog
cr24Team23:12
i don't think there should be holystone bricks in there
or maybe a lower %
Deleted User23:27
You need to check if the player is under y = -1 and take damage
@Azzyypaaras
In the mixin
Instead of take damage however
AzzyypaarasTeam23:29
What?
Deleted User23:29
[kalucky0/The-Aether] Issue opened: #16 Having your head in a block in the Aether sends you to the overworld
cr24Team23:29
lol weirdest bug yet
Deleted User23:29
When the player falls off the aether
It teleports them to overworld
AzzyypaarasTeam23:30
Deleted User23:30
It tps when they take damage
You forgot to check if they were actually in the void
And not taking damage from fall damage etc.
cr24Team23:30
I was in creative mode...
Deleted User23:30
So check if the player is under y=-1
@cr24 you still suffocate in creative
And take "0" damage
Which still fires the ondamage mixin
Which tps you to the overworld and you fall through the clouds
cr24Team23:33
oh thats weird
Deleted User23:33
Well, it works to cancel void death
Try jumping off the aether
Youll see what i mean
cr24Team23:35
I see
AzzyypaarasTeam23:42
WHOMSTS HAS MADE ALL OF THE CONSTANT FIELDS LOWERCASE